[CXF-6059] Add a better error message if an invalid wsdl is used.
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/a4d82fe2 Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/a4d82fe2 Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/a4d82fe2 Branch: refs/heads/3.0.x-fixes Commit: a4d82fe2908471335bebd85a88728605aff15084 Parents: 702a29a Author: Daniel Kulp <[email protected]> Authored: Mon Oct 27 13:46:43 2014 -0400 Committer: Daniel Kulp <[email protected]> Committed: Mon Oct 27 13:51:45 2014 -0400 ---------------------------------------------------------------------- .../org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf/blob/a4d82fe2/rt/wsdl/src/main/java/org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java ---------------------------------------------------------------------- diff --git a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java index bf93bc5..98927a9 100644 --- a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java +++ b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/binding/AbstractWSDLBindingFactory.java @@ -32,6 +32,7 @@ import javax.xml.namespace.QName; import org.apache.cxf.Bus; import org.apache.cxf.binding.AbstractBindingFactory; +import org.apache.cxf.common.util.StringUtils; import org.apache.cxf.service.model.AbstractPropertiesHolder; import org.apache.cxf.service.model.BindingInfo; import org.apache.cxf.service.model.BindingOperationInfo; @@ -102,6 +103,10 @@ public abstract class AbstractWSDLBindingFactory extends AbstractBindingFactory copyExtensors(bop2.getOutput(), bop.getBindingOutput(), bop2); } for (BindingFault f : cast(bop.getBindingFaults().values(), BindingFault.class)) { + if (StringUtils.isEmpty(f.getName())) { + throw new IllegalArgumentException("wsdl:fault and soap:fault elements" + + " must have a name attribute."); + } copyExtensors(bop2.getFault(new QName(service.getTargetNamespace(), f.getName())), bop.getBindingFault(f.getName()), bop2); }
