Repository: cxf Updated Branches: refs/heads/3.0.x-fixes 8a8b282ce -> 37e743ec8
[CXF-6901] Fixing an issue with resolving the query templates Project: http://git-wip-us.apache.org/repos/asf/cxf/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/37e743ec Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/37e743ec Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/37e743ec Branch: refs/heads/3.0.x-fixes Commit: 37e743ec8540788907cd9e36c4ffc120aa916c0e Parents: 8a8b282 Author: Sergey Beryozkin <[email protected]> Authored: Mon May 16 13:05:19 2016 +0100 Committer: Sergey Beryozkin <[email protected]> Committed: Mon May 16 13:07:34 2016 +0100 ---------------------------------------------------------------------- .../main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java | 2 +- .../java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf/blob/37e743ec/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java ---------------------------------------------------------------------- diff --git a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java index f04c4d0..6de6a81 100644 --- a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java +++ b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java @@ -291,7 +291,7 @@ public class UriBuilderImpl extends UriBuilder implements Cloneable { ? Collections.<String>emptySet() : new HashSet<String>(); for (String var : uniqueVars) { - boolean resolvedPathVarHasToBeEncoded = !isQuery && alreadyResolvedTsPathEnc.containsKey(var); + boolean resolvedPathVarHasToBeEncoded = alreadyResolvedTsPathEnc.containsKey(var); boolean varValueHasToBeEncoded = resolvedPathVarHasToBeEncoded || alreadyResolvedTs.containsKey(var); Map<String, Object> resolved = !varValueHasToBeEncoded ? alreadyResolvedTsEnc http://git-wip-us.apache.org/repos/asf/cxf/blob/37e743ec/rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java ---------------------------------------------------------------------- diff --git a/rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java b/rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java index a9ec843..5ed3bac 100644 --- a/rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java +++ b/rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/impl/UriBuilderImplTest.java @@ -265,6 +265,13 @@ public class UriBuilderImplTest extends Assert { .build("valueA", "valueB"); assertEquals("/index.jsp?a=valueA&b=valueB", uri.toString()); } + + @Test + public void testResolveTemplateInQuery() { + String uri = UriBuilder.fromPath("my/path").queryParam("qp", + "{param}").resolveTemplate("param", "value").toTemplate(); + assertEquals("my/path?qp=value", uri.toString()); + } @Test(expected = IllegalArgumentException.class) public void testQueryParamWithMissingTemplateValues() {
