Removing "TODO" code due to impending WSS4J release
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/97fc24b1 Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/97fc24b1 Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/97fc24b1 Branch: refs/heads/3.1.x-fixes Commit: 97fc24b158d3deb18a388a49b01b3436e6c7b1b7 Parents: f09bcb5 Author: Colm O hEigeartaigh <[email protected]> Authored: Mon Jul 25 11:33:29 2016 +0100 Committer: Colm O hEigeartaigh <[email protected]> Committed: Mon Jul 25 11:33:29 2016 +0100 ---------------------------------------------------------------------- .../wss4j/PolicyBasedWSS4JInInterceptor.java | 74 -------------------- 1 file changed, 74 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf/blob/97fc24b1/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/PolicyBasedWSS4JInInterceptor.java ---------------------------------------------------------------------- diff --git a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/PolicyBasedWSS4JInInterceptor.java b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/PolicyBasedWSS4JInInterceptor.java index 962b5ce..0370c75 100644 --- a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/PolicyBasedWSS4JInInterceptor.java +++ b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/PolicyBasedWSS4JInInterceptor.java @@ -24,8 +24,6 @@ import java.util.Collection; import java.util.HashSet; import java.util.List; import java.util.Map; -import java.util.Properties; -import java.util.logging.Logger; import javax.xml.namespace.QName; import javax.xml.soap.SOAPException; @@ -33,7 +31,6 @@ import javax.xml.stream.XMLStreamException; import org.w3c.dom.Element; import org.apache.cxf.binding.soap.SoapMessage; -import org.apache.cxf.common.logging.LogUtils; import org.apache.cxf.helpers.CastUtils; import org.apache.cxf.interceptor.Fault; import org.apache.cxf.message.MessageUtils; @@ -46,10 +43,8 @@ import org.apache.cxf.ws.security.wss4j.policyvalidators.PolicyValidatorParamete import org.apache.cxf.ws.security.wss4j.policyvalidators.SecurityPolicyValidator; import org.apache.cxf.ws.security.wss4j.policyvalidators.ValidatorUtils; import org.apache.wss4j.common.crypto.Crypto; -import org.apache.wss4j.common.crypto.CryptoFactory; import org.apache.wss4j.common.crypto.PasswordEncryptor; import org.apache.wss4j.common.ext.WSSecurityException; -import org.apache.wss4j.common.util.Loader; import org.apache.wss4j.dom.WSConstants; import org.apache.wss4j.dom.WSDataRef; import org.apache.wss4j.dom.engine.WSSecurityEngineResult; @@ -70,8 +65,6 @@ import org.apache.wss4j.policy.model.Wss11; */ public class PolicyBasedWSS4JInInterceptor extends WSS4JInInterceptor { - private static final Logger LOG = LogUtils.getL7dLogger(PolicyBasedWSS4JInInterceptor.class); - /** * */ @@ -88,73 +81,6 @@ public class PolicyBasedWSS4JInInterceptor extends WSS4JInInterceptor { } } - /** - * TODO - This method can be removed when WSS4J 2.1.7 is released - see WSS-582 - * - * Load a Crypto instance. Firstly, it tries to use the cryptoPropertyRefId tag to retrieve - * a Crypto object via a custom reference Id. Failing this, it tries to load the crypto - * instance via the cryptoPropertyFile tag. - * - * @param requestData the RequestData object - * @return a Crypto instance to use for Encryption creation/verification - */ - @Override - protected Crypto loadCrypto( - String cryptoPropertyFile, - String cryptoPropertyRefId, - RequestData requestData - ) throws WSSecurityException { - Object mc = requestData.getMsgContext(); - Crypto crypto = null; - - // - // Try the Property Ref Id first - // - String refId = getString(cryptoPropertyRefId, mc); - if (refId != null) { - crypto = cryptos.get(refId); - if (crypto == null) { - Object obj = getProperty(mc, refId); - if (obj instanceof Properties) { - crypto = CryptoFactory.getInstance((Properties)obj, - Loader.getClassLoader(CryptoFactory.class), - getPasswordEncryptor(requestData)); - cryptos.put(refId, crypto); - } else if (obj instanceof Crypto) { - // No need to cache this as it's already loaded - crypto = (Crypto)obj; - } - } - if (crypto == null) { - LOG.warning("The Crypto reference " + refId + " specified by " - + cryptoPropertyRefId + " could not be loaded" - ); - } - } - - // - // Now try loading the properties file - // - if (crypto == null) { - String propFile = getString(cryptoPropertyFile, mc); - if (propFile != null) { - crypto = cryptos.get(propFile); - if (crypto == null) { - crypto = loadCryptoFromPropertiesFile(propFile, requestData); - cryptos.put(propFile, crypto); - } - if (crypto == null) { - LOG.warning( - "The Crypto properties file " + propFile + " specified by " - + cryptoPropertyFile + " could not be loaded or found" - ); - } - } - } - - return crypto; - } - private void handleWSS11(AssertionInfoMap aim, SoapMessage message) { if (isRequestor(message)) { message.put(WSHandlerConstants.ENABLE_SIGNATURE_CONFIRMATION, "false");
