Start going through the "TODO Auto-generated catch block"'s to figure out what 
should be done


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/b69bd427
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/b69bd427
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/b69bd427

Branch: refs/heads/master
Commit: b69bd427318a9f6db6e6e7940796cb233aa54ef9
Parents: 5f277de
Author: Daniel Kulp <dk...@apache.org>
Authored: Thu Aug 10 14:07:48 2017 -0400
Committer: Daniel Kulp <dk...@apache.org>
Committed: Thu Aug 10 14:07:48 2017 -0400

----------------------------------------------------------------------
 .../apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java  | 3 +--
 .../src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java     | 4 +---
 .../cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java   | 1 -
 .../cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java     | 4 ----
 .../src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java  | 2 +-
 .../cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java     | 1 -
 .../apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java | 1 -
 7 files changed, 3 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java
----------------------------------------------------------------------
diff --git 
a/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java
 
b/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java
index df4f605..7d32846 100644
--- 
a/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java
+++ 
b/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/handler/AnnotationHandlerChainBuilder.java
@@ -284,8 +284,7 @@ public class AnnotationHandlerChainBuilder extends 
HandlerChainBuilder {
             PortComponentHandlerType pt = JAXBUtils.unmarshall(ctx, el, 
PortComponentHandlerType.class).getValue();
             chain.addAll(buildHandlerChain(pt, classLoader));
         } catch (JAXBException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            throw new IllegalArgumentException("Could not unmarshal handler 
chain", e);
         }
     }
 

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java
----------------------------------------------------------------------
diff --git 
a/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java 
b/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java
index 3b91b72..e9691cf 100644
--- a/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java
+++ b/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/spi/ProviderImpl.java
@@ -203,12 +203,10 @@ public class ProviderImpl extends 
javax.xml.ws.spi.Provider {
                 um = context.createUnmarshaller();
                 return um.unmarshal(reader, 
EndpointReferenceType.class).getValue();
             } catch (JAXBException e) {
-                // TODO Auto-generated catch block
-                e.printStackTrace();
+                throw new IllegalArgumentException("Could not unmarshal 
EndpointReference", e);
             } finally {
                 JAXBUtils.closeUnmarshaller(um);
             }
-            return null;
         }
         return null;
     }

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java
----------------------------------------------------------------------
diff --git 
a/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java
 
b/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java
index 0f0da70..5787c5f 100644
--- 
a/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java
+++ 
b/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/MtoMParameterBeanNoDataHandler.java
@@ -47,7 +47,6 @@ public class MtoMParameterBeanNoDataHandler {
         try {
             this.notXml10 = new String(notXml10, "utf-8");
         } catch (UnsupportedEncodingException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
         }
     }

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/rt/transports/http-hc/src/test/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java
----------------------------------------------------------------------
diff --git 
a/rt/transports/http-hc/src/test/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java
 
b/rt/transports/http-hc/src/test/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java
index 36cfc45..f86eff9 100644
--- 
a/rt/transports/http-hc/src/test/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java
+++ 
b/rt/transports/http-hc/src/test/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduitTest.java
@@ -197,10 +197,8 @@ public class AsyncHTTPConduitTest extends 
AbstractBusClientServerTestBase {
                 try {
                     res.get().getResponseType();
                 } catch (InterruptedException e) {
-                    // TODO Auto-generated catch block
                     e.printStackTrace();
                 } catch (ExecutionException e) {
-                    // TODO Auto-generated catch block
                     e.printStackTrace();
                 }
             }
@@ -292,10 +290,8 @@ public class AsyncHTTPConduitTest extends 
AbstractBusClientServerTestBase {
                             System.out.println("Problem " + c + " != " + s);
                         }
                     } catch (InterruptedException e) {
-                        // TODO Auto-generated catch block
                         e.printStackTrace();
                     } catch (ExecutionException e) {
-                        // TODO Auto-generated catch block
                         e.printStackTrace();
                     }
                     wdone[c] = true;

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java
----------------------------------------------------------------------
diff --git 
a/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java 
b/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java
index 1801b4d..2d8d6e7 100644
--- a/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java
+++ b/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/CatalogWSDLLocator.java
@@ -116,7 +116,7 @@ public class CatalogWSDLLocator implements WSDLLocator {
             in = this.resolver.resolve(resolvedImportLocation, null);
         }
 
-        // XXX: If we return null (as per javadoc), a NPE is raised in WSDL4J 
code.
+        // If we return null (as per javadoc), a NPE is raised in WSDL4J code.
         // So let's return new InputSource() and let WSDL4J fail. Optionally,
         // we can throw a similar exception as in CatalogXmlSchemaURIResolver.
         if (in == null) {

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java
----------------------------------------------------------------------
diff --git 
a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java
 
b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java
index 0187319..c9495ba 100644
--- 
a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java
+++ 
b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/DocLitWrappedCodeFirstServiceImpl.java
@@ -218,7 +218,6 @@ public class DocLitWrappedCodeFirstServiceImpl implements 
DocLitWrappedCodeFirst
         try {
             Thread.sleep(2000);
         } catch (InterruptedException e) {
-            // TODO Auto-generated catch block
             e.printStackTrace();
         }
     }

http://git-wip-us.apache.org/repos/asf/cxf/blob/b69bd427/systests/ws-security/src/test/java/org/apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java
----------------------------------------------------------------------
diff --git 
a/systests/ws-security/src/test/java/org/apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java
 
b/systests/ws-security/src/test/java/org/apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java
index 053259d..a41d9cf 100644
--- 
a/systests/ws-security/src/test/java/org/apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java
+++ 
b/systests/ws-security/src/test/java/org/apache/cxf/systest/ws/ut/SecurityHeaderCacheInterceptor.java
@@ -81,7 +81,6 @@ public class SecurityHeaderCacheInterceptor implements 
PhaseInterceptor<SoapMess
                 }
 
             } catch (SOAPException e) {
-                // TODO Auto-generated catch block
                 e.printStackTrace();
             }
         }

Reply via email to