Cleanup TODO's in bindings/corba
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/e9a8d1ac Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/e9a8d1ac Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/e9a8d1ac Branch: refs/heads/master Commit: e9a8d1ac4485e2820b33eebe8efe1c504c734e1e Parents: b0399bf Author: Daniel Kulp <[email protected]> Authored: Wed Aug 16 14:55:33 2017 -0400 Committer: Daniel Kulp <[email protected]> Committed: Wed Aug 16 14:55:33 2017 -0400 ---------------------------------------------------------------------- .../src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java | 2 +- .../main/java/org/apache/cxf/binding/corba/CorbaDestination.java | 1 - .../src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java | 2 -- .../binding/corba/interceptors/CorbaStreamFaultInInterceptor.java | 2 -- .../org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java | 3 ++- .../org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java | 3 ++- .../org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java | 2 -- .../org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java | 2 +- .../main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java | 2 -- 9 files changed, 6 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java index 7004b65..5cc2e0c 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java @@ -260,7 +260,7 @@ public class CorbaConduit implements Conduit { retVal.getObject().setIntoAny(returnAny, retVal, false); ret = orb.create_named_value(retVal.getName(), returnAny, org.omg.CORBA.ARG_OUT.value); } else { - // TODO: REVISIT: for some reason, some ORBs do not like to + // for some reason, some ORBs do not like to // have a null NamedValue return value. Create this 'empty' // one if a void return type is used. ret = orb.create_named_value("return", orb.create_any(), org.omg.CORBA.ARG_OUT.value); http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaDestination.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaDestination.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaDestination.java index ad89d45..eef037f 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaDestination.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaDestination.java @@ -312,7 +312,6 @@ public class CorbaDestination implements MultiplexDestination { populateEpr(orb.object_to_string(obj)); LOG.info("Object Reference: " + orb.object_to_string(obj)); - // TODO: Provide other export mechanisms? poaManager.activate(); } catch (Exception ex) { throw new CorbaBindingException("Unable to activate CORBA servant", ex); http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java index bf66254..56f9bb8 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaMessage.java @@ -124,7 +124,6 @@ public class CorbaMessage extends AbstractWrappedMessage { } public void setStreamableReturnValue(CorbaObjectHandler data) { - // TODO: Handle case of the return parameter has not yet been initialized. returnParam.setObject(data); } @@ -133,7 +132,6 @@ public class CorbaMessage extends AbstractWrappedMessage { } public void setStreamableExceptionValue(CorbaObjectHandler exData) { - // TODO: Handle case of the return parameter has not yet been initialized. except.setObject(exData); } http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/interceptors/CorbaStreamFaultInInterceptor.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/interceptors/CorbaStreamFaultInInterceptor.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/interceptors/CorbaStreamFaultInInterceptor.java index 662b93e..084e070 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/interceptors/CorbaStreamFaultInInterceptor.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/interceptors/CorbaStreamFaultInInterceptor.java @@ -73,8 +73,6 @@ public class CorbaStreamFaultInInterceptor extends AbstractPhaseInterceptor<Mess SystemException sysEx = message.getSystemException(); if (sysEx != null) { - // TODO: Do we need anything else to handle system exceptions here...i.e. do - // we want to add a wrapper around this so that we can add some more information? message.setContent(Exception.class, sysEx); return; } http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java index 2c98528..c50279f 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java @@ -143,7 +143,8 @@ public class CorbaObjectReader { this.readObjectReference((CorbaObjectReferenceHandler)obj); break; default: - // TODO: Provide Implementation. Do we throw an exception. + throw new CorbaBindingException("CorbaObjectReader: unhandled TypeCode.Kind: " + + obj.getTypeCode().kind().value()); } } http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java index d4de7c4..7e5722e 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectWriter.java @@ -128,7 +128,8 @@ public class CorbaObjectWriter { this.writeObjectReference((CorbaObjectReferenceHandler)obj); break; default: - // TODO: Provide Implementation. Do we throw an exception. + throw new CorbaBindingException("CorbaObjectWriter: unhandled TypeCode.Kind: " + + obj.getTypeCode().kind().value()); } } http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java index f3922f5..fee0266 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaExceptionHandler.java @@ -78,6 +78,4 @@ public class CorbaExceptionHandler extends CorbaObjectHandler { members.get(i).clear(); } } - - // TODO: Can we add the features that exist in the main package here? } http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java index d4726cc..adaacce 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaHandlerUtils.java @@ -163,7 +163,7 @@ public final class CorbaHandlerUtils { break; default: - // TODO: Should we raise an exception or log? + //nothing to do, the Read/Write routines will throw exceptions } } return obj; http://git-wip-us.apache.org/repos/asf/cxf/blob/e9a8d1ac/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java ---------------------------------------------------------------------- diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java index 77b52f3..7bf1431 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaUtils.java @@ -214,7 +214,6 @@ public final class CorbaUtils { } else if (obj instanceof Exception) { Exception exceptType = (Exception)obj; - // TODO: check to see if this is a recursive type. List<MemberType> list = exceptType.getMember(); StructMember[] members = new StructMember[list.size()]; for (int i = 0; i < members.length; ++i) { @@ -244,7 +243,6 @@ public final class CorbaUtils { } else if (obj instanceof Struct) { Struct structType = (Struct)obj; - // TODO: check to see if this is a recursive type. if (seenTypes.contains(new QName(structType.getName()))) { tc = orb.create_recursive_tc(structType.getRepositoryID()); } else {
