This is an automated email from the ASF dual-hosted git repository.
coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cxf.git
The following commit(s) were added to refs/heads/master by this push:
new 13e1dae Using isEmpty instead of size() == 0 etc.
13e1dae is described below
commit 13e1dae57f5609259f935bfe5e280862e266dcb2
Author: Colm O hEigeartaigh <[email protected]>
AuthorDate: Fri Feb 15 18:14:53 2019 +0000
Using isEmpty instead of size() == 0 etc.
---
.../java/org/apache/cxf/bus/extension/ExtensionManagerBus.java | 2 +-
.../java/org/apache/cxf/bus/spring/BusApplicationContext.java | 2 +-
core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java | 2 +-
.../org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java | 4 ++--
.../java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java | 4 ++--
.../src/main/java/org/apache/cxf/binding/coloc/ColocUtil.java | 4 ++--
.../org/apache/cxf/binding/corba/types/CorbaUnionListener.java | 2 +-
.../src/main/java/org/apache/cxf/binding/soap/SoapMessage.java | 2 +-
.../src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java | 2 +-
.../main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java | 2 +-
.../java/org/apache/cxf/jaxrs/model/wadl/WadlGeneratorTest.java | 2 +-
.../cxf/microprofile/client/cdi/CDIInterceptorWrapperImpl.java | 2 +-
.../cxf/rs/security/cors/CrossOriginResourceSharingFilter.java | 2 +-
.../http/src/main/java/org/apache/cxf/transport/http/Headers.java | 2 +-
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMManager.java | 8 ++++----
.../main/java/org/apache/cxf/ws/rm/soap/RedeliveryQueueImpl.java | 4 ++--
.../java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java | 2 +-
.../apache/cxf/ws/security/wss4j/AttachmentCallbackHandler.java | 6 +++---
.../policyvalidators/AbstractSupportingTokenPolicyValidator.java | 2 +-
.../ws/security/wss4j/policyvalidators/LayoutPolicyValidator.java | 2 +-
.../apache/cxf/ws/security/wss4j/SignatureConfirmationTest.java | 4 ++--
.../cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java | 2 +-
.../java/org/apache/cxf/sts/claims/LdapGroupClaimsHandler.java | 2 +-
.../org/apache/cxf/tools/corba/common/idltypes/IdlOperation.java | 2 +-
.../apache/cxf/tools/corba/processors/wsdl/WSDLToIDLAction.java | 2 +-
.../java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java | 2 +-
.../apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java | 2 +-
27 files changed, 37 insertions(+), 37 deletions(-)
diff --git
a/core/src/main/java/org/apache/cxf/bus/extension/ExtensionManagerBus.java
b/core/src/main/java/org/apache/cxf/bus/extension/ExtensionManagerBus.java
index de67988..f9163fc 100644
--- a/core/src/main/java/org/apache/cxf/bus/extension/ExtensionManagerBus.java
+++ b/core/src/main/java/org/apache/cxf/bus/extension/ExtensionManagerBus.java
@@ -188,7 +188,7 @@ public class ExtensionManagerBus extends
AbstractBasicInterceptorProvider implem
} else {
//force loading
Collection<?> objs = loc.getBeansOfType(extensionType);
- if (objs != null && objs.size() != 0) {
+ if (objs != null && !objs.isEmpty()) {
extensions.put(extensionType, objs.iterator().next());
}
obj = extensions.get(extensionType);
diff --git
a/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationContext.java
b/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationContext.java
index 591760e..5924881 100644
--- a/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationContext.java
+++ b/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationContext.java
@@ -233,7 +233,7 @@ public class BusApplicationContext extends
ClassPathXmlApplicationContext {
LOG.fine("Creating application context with resources: " +
resources);
}
- if (0 == resources.size()) {
+ if (resources.isEmpty()) {
return null;
}
Resource[] res = new Resource[resources.size()];
diff --git a/core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java
b/core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java
index 14f7dfc..a4af350 100644
--- a/core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java
+++ b/core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java
@@ -73,7 +73,7 @@ public class FileUtilsTest {
assertTrue(directory.exists());
List<File> foundFiles = FileUtils.getFilesUsingSuffix(directory,
".class");
- assertTrue(foundFiles.size() > 0);
+ assertTrue(!foundFiles.isEmpty());
List<File> foundFiles2 = FileUtils.getFiles(directory, ".*\\.class$");
diff --git
a/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java
b/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java
index a451e46..7b1ba9d 100644
---
a/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java
+++
b/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java
@@ -103,7 +103,7 @@ public final class WsdlOptionLoader {
private static String[] readOptionsFromFile(File dir, String wsdlName)
throws MojoExecutionException {
String[] noOptions = new String[] {};
List<File> files = FileUtils.getFiles(dir, wsdlName + WSDL_OPTIONS);
- if (files.size() <= 0) {
+ if (files.isEmpty()) {
return noOptions;
}
File optionsFile = files.iterator().next();
@@ -112,7 +112,7 @@ public final class WsdlOptionLoader {
}
try {
List<String> lines = FileUtils.readLines(optionsFile);
- if (lines.size() <= 0) {
+ if (lines.isEmpty()) {
return noOptions;
}
return lines.iterator().next().split(" ");
diff --git
a/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java
b/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java
index f6ffda4..d3e9115 100644
---
a/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java
+++
b/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java
@@ -187,7 +187,7 @@ public final class OptionLoader {
private static String[] readOptionsFromFile(File dir, String wsdlName)
throws MojoExecutionException {
String[] noOptions = new String[] {};
List<File> files = FileUtils.getFiles(dir, wsdlName + WADL_OPTIONS);
- if (files.size() <= 0) {
+ if (files.isEmpty()) {
return noOptions;
}
File optionsFile = files.iterator().next();
@@ -196,7 +196,7 @@ public final class OptionLoader {
}
try {
List<String> lines = FileUtils.readLines(optionsFile);
- if (lines.size() <= 0) {
+ if (lines.isEmpty()) {
return noOptions;
}
return lines.iterator().next().split(" ");
diff --git
a/rt/bindings/coloc/src/main/java/org/apache/cxf/binding/coloc/ColocUtil.java
b/rt/bindings/coloc/src/main/java/org/apache/cxf/binding/coloc/ColocUtil.java
index 385f717..cbc95eb 100644
---
a/rt/bindings/coloc/src/main/java/org/apache/cxf/binding/coloc/ColocUtil.java
+++
b/rt/bindings/coloc/src/main/java/org/apache/cxf/binding/coloc/ColocUtil.java
@@ -250,7 +250,7 @@ public final class ColocUtil {
public static void convertSourceToObject(Message message) {
List<Object> content = CastUtils.cast(message.getContent(List.class));
- if (content == null || content.size() < 1) {
+ if (content == null || content.isEmpty()) {
// nothing to convert
return;
}
@@ -279,7 +279,7 @@ public final class ColocUtil {
public static void convertObjectToSource(Message message) {
List<Object> content = CastUtils.cast(message.getContent(List.class));
- if (content == null || content.size() < 1) {
+ if (content == null || content.isEmpty()) {
// nothing to convert
return;
}
diff --git
a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaUnionListener.java
b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaUnionListener.java
index 0a48805..59405bc 100644
---
a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaUnionListener.java
+++
b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaUnionListener.java
@@ -134,7 +134,7 @@ public class CorbaUnionListener extends
AbstractCorbaTypeListener {
String descriminatorValue;
// Determine the value of the discriminator.
List<CaseType> branchCases = branch.getCase();
- if (branchCases.size() != 0) {
+ if (!branchCases.isEmpty()) {
CaseType caseLabel = branchCases.get(0);
descriminatorValue = caseLabel.getLabel();
} else {
diff --git
a/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/SoapMessage.java
b/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/SoapMessage.java
index d6dbf0f..614eaa1 100644
---
a/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/SoapMessage.java
+++
b/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/SoapMessage.java
@@ -79,7 +79,7 @@ public class SoapMessage extends MessageImpl {
}
public boolean hasHeaders() {
- return containsKey(Header.HEADER_LIST) && getHeaders().size() > 0;
+ return containsKey(Header.HEADER_LIST) && !getHeaders().isEmpty();
}
public Map<String, String> getEnvelopeNs() {
diff --git
a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java
b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java
index 2cbc951..7cb0db1 100644
--- a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java
+++ b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/RequestImpl.java
@@ -107,7 +107,7 @@ public class RequestImpl implements Request {
List<Variant> requestVars = new LinkedList<>();
for (MediaType mt : mediaTypes) {
for (Locale lang : langs) {
- if (encs.size() < 1) {
+ if (encs.isEmpty()) {
requestVars.add(new Variant(mt, lang, null));
} else {
for (String enc : encs) {
diff --git
a/rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
b/rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
index 9526de4..c80d176 100644
---
a/rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
+++
b/rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
@@ -242,7 +242,7 @@ public class WadlGenerator implements
ContainerRequestFilter {
return;
}
- if (whiteList != null && whiteList.size() > 0) {
+ if (whiteList != null && !whiteList.isEmpty()) {
ServletRequest servletRequest =
(ServletRequest)m.getContextualProperty(
"HTTP.REQUEST");
String remoteAddress = null;
diff --git
a/rt/rs/description/src/test/java/org/apache/cxf/jaxrs/model/wadl/WadlGeneratorTest.java
b/rt/rs/description/src/test/java/org/apache/cxf/jaxrs/model/wadl/WadlGeneratorTest.java
index 4e622e7..4a5cbf3 100644
---
a/rt/rs/description/src/test/java/org/apache/cxf/jaxrs/model/wadl/WadlGeneratorTest.java
+++
b/rt/rs/description/src/test/java/org/apache/cxf/jaxrs/model/wadl/WadlGeneratorTest.java
@@ -1024,7 +1024,7 @@ public class WadlGeneratorTest {
List<Element> importEls =
DOMUtils.getChildrenWithName(schemasEls.get(0),
Constants.URI_2001_SCHEMA_XSD,
"import");
- int schemaElementsIndex = importEls.size() > 0 ? 0 : 1;
+ int schemaElementsIndex = !importEls.isEmpty() ? 0 : 1;
int schemaTypesIndex = schemaElementsIndex == 0 ? 1 : 0;
checkGenericImplSchemaWithTypes(schemasEls.get(schemaTypesIndex));
diff --git
a/rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/cdi/CDIInterceptorWrapperImpl.java
b/rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/cdi/CDIInterceptorWrapperImpl.java
index 3e68de4..223922d 100644
---
a/rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/cdi/CDIInterceptorWrapperImpl.java
+++
b/rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/cdi/CDIInterceptorWrapperImpl.java
@@ -113,7 +113,7 @@ class CDIInterceptorWrapperImpl implements
CDIInterceptorWrapper {
}
private static List<Annotation> getBindings(Set<Annotation> annotations,
BeanManager beanManager) {
- if (annotations == null || annotations.size() == 0) {
+ if (annotations == null || annotations.isEmpty()) {
return Collections.emptyList();
}
List<Annotation> bindings = new ArrayList<>();
diff --git
a/rt/rs/security/cors/src/main/java/org/apache/cxf/rs/security/cors/CrossOriginResourceSharingFilter.java
b/rt/rs/security/cors/src/main/java/org/apache/cxf/rs/security/cors/CrossOriginResourceSharingFilter.java
index 3006440..eab3175 100644
---
a/rt/rs/security/cors/src/main/java/org/apache/cxf/rs/security/cors/CrossOriginResourceSharingFilter.java
+++
b/rt/rs/security/cors/src/main/java/org/apache/cxf/rs/security/cors/CrossOriginResourceSharingFilter.java
@@ -150,7 +150,7 @@ public class CrossOriginResourceSharingFilter implements
ContainerRequestFilter,
// 5.1.4
List<String> effectiveExposeHeaders = effectiveExposeHeaders(ann);
- if (effectiveExposeHeaders != null && effectiveExposeHeaders.size() !=
0) {
+ if (effectiveExposeHeaders != null &&
!effectiveExposeHeaders.isEmpty()) {
m.getExchange().put(CorsHeaderConstants.HEADER_AC_EXPOSE_HEADERS,
effectiveExposeHeaders);
}
diff --git
a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/Headers.java
b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/Headers.java
index 48fc0ef..3790076 100644
---
a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/Headers.java
+++
b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/Headers.java
@@ -438,7 +438,7 @@ public class Headers {
}
for (Enumeration<String> e2 = req.getHeaders(fname);
e2.hasMoreElements();) {
String val = e2.nextElement();
- if ("Accept".equals(mappedName) && values.size() > 0) {
+ if ("Accept".equals(mappedName) && !values.isEmpty()) {
//ensure we collapse Accept into first line
String firstAccept = values.get(0);
firstAccept = firstAccept + ", " + val;
diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMManager.java
b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMManager.java
index 4ff1e1f..c396627 100644
--- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMManager.java
+++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMManager.java
@@ -142,7 +142,7 @@ public class RMManager {
}
String id = RMUtils.getEndpointIdentifier(client.getEndpoint(),
getBus());
Collection<SourceSequence> sss = store.getSourceSequences(id/*,
protocol*/);
- if (null == sss || 0 == sss.size()) {
+ if (null == sss || sss.isEmpty()) {
return;
}
LOG.log(Level.FINE, "Number of source sequences: {0}", sss.size());
@@ -559,7 +559,7 @@ public class RMManager {
Collection<SourceSequence> sss = store.getSourceSequences(id);
Collection<DestinationSequence> dss =
store.getDestinationSequences(id);
- if ((null == sss || 0 == sss.size()) && (null == dss || 0 ==
dss.size())) {
+ if ((null == sss || sss.isEmpty()) && (null == dss || dss.isEmpty())) {
return;
}
LOG.log(Level.FINE, "Number of source sequences: {0}", sss.size());
@@ -586,7 +586,7 @@ public class RMManager {
private void recoverSourceSequence(Endpoint endpoint, Conduit conduit,
Source s,
SourceSequence ss) {
Collection<RMMessage> ms = store.getMessages(ss.getIdentifier(), true);
- if (null == ms || 0 == ms.size()) {
+ if (null == ms || ms.isEmpty()) {
store.removeSourceSequence(ss.getIdentifier());
return;
}
@@ -653,7 +653,7 @@ public class RMManager {
d.addSequence(ds, false);
Collection<RMMessage> ms = store.getMessages(ds.getIdentifier(),
false);
- if (null == ms || 0 == ms.size()) {
+ if (null == ms || ms.isEmpty()) {
return;
}
LOG.log(Level.FINE, "Number of messages in sequence: {0}", ms.size());
diff --git
a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RedeliveryQueueImpl.java
b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RedeliveryQueueImpl.java
index b62831d..5508a97 100644
--- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RedeliveryQueueImpl.java
+++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RedeliveryQueueImpl.java
@@ -114,7 +114,7 @@ public class RedeliveryQueueImpl implements RedeliveryQueue
{
}
public boolean isEmpty() {
- return 0 == getUndelivered().size();
+ return getUndelivered().isEmpty();
}
public void purgeAll(DestinationSequence seq) {
Collection<Long> purged = new ArrayList<>();
@@ -699,4 +699,4 @@ public class RedeliveryQueueImpl implements RedeliveryQueue
{
}
}
}
-}
\ No newline at end of file
+}
diff --git
a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
index d3b3abd..08d489d 100644
---
a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
+++
b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
@@ -151,7 +151,7 @@ public class RetransmissionQueueImpl implements
RetransmissionQueue {
* @return true if there are no unacknowledged messages in the queue
*/
public boolean isEmpty() {
- return 0 == getUnacknowledged().size();
+ return getUnacknowledged().isEmpty();
}
/**
diff --git
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/AttachmentCallbackHandler.java
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/AttachmentCallbackHandler.java
index 959f119..1246190 100644
---
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/AttachmentCallbackHandler.java
+++
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/AttachmentCallbackHandler.java
@@ -95,8 +95,8 @@ public class AttachmentCallbackHandler implements
CallbackHandler {
if (attachmentId != null) {
final Collection<org.apache.cxf.message.Attachment>
attachments = soapMessage.getAttachments();
// Calling LazyAttachmentCollection.size() here to force
it to load the attachments
- if (attachments != null && attachments.size() > 0) {
- for (Iterator<org.apache.cxf.message.Attachment>
iterator = attachments.iterator();
+ if (attachments != null && attachments.size() > 0) { //
NOPMD
+ for (Iterator<org.apache.cxf.message.Attachment>
iterator = attachments.iterator();
iterator.hasNext();) {
org.apache.cxf.message.Attachment attachment =
iterator.next();
@@ -120,7 +120,7 @@ public class AttachmentCallbackHandler implements
CallbackHandler {
) throws IOException {
final Collection<org.apache.cxf.message.Attachment> attachments =
soapMessage.getAttachments();
// Calling LazyAttachmentCollection.size() here to force it to load
the attachments
- if (attachments != null && attachments.size() > 0) {
+ if (attachments != null && attachments.size() > 0) { // NOPMD
for (Iterator<org.apache.cxf.message.Attachment> iterator =
attachments.iterator();
iterator.hasNext();) {
org.apache.cxf.message.Attachment attachment = iterator.next();
diff --git
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/AbstractSupportingTokenPolicyValidator.java
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/AbstractSupportingTokenPolicyValidator.java
index 7c81dc0..5749192 100644
---
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/AbstractSupportingTokenPolicyValidator.java
+++
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/AbstractSupportingTokenPolicyValidator.java
@@ -560,7 +560,7 @@ public abstract class
AbstractSupportingTokenPolicyValidator extends AbstractSec
CastUtils.cast((List<?>)signedResult.get(
WSSecurityEngineResult.TAG_DATA_REF_URIS
));
- if (sl != null && sl.size() >= 1) {
+ if (sl != null && !sl.isEmpty()) {
for (WSDataRef dataRef : sl) {
QName signedQName = dataRef.getName();
if (WSConstants.SIGNATURE.equals(signedQName)
diff --git
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/LayoutPolicyValidator.java
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/LayoutPolicyValidator.java
index 70f7ed7..146bc34 100644
---
a/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/LayoutPolicyValidator.java
+++
b/rt/ws/security/src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/LayoutPolicyValidator.java
@@ -188,7 +188,7 @@ public class LayoutPolicyValidator extends
AbstractSecurityPolicyValidator {
CastUtils.cast((List<?>)signedResult.get(
WSSecurityEngineResult.TAG_DATA_REF_URIS
));
- if (sl != null && sl.size() >= 1) {
+ if (sl != null && !sl.isEmpty()) {
for (WSDataRef dataRef : sl) {
QName signedQName = dataRef.getName();
if (WSConstants.SIGNATURE.equals(signedQName)) {
diff --git
a/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/SignatureConfirmationTest.java
b/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/SignatureConfirmationTest.java
index de00bd1..ff83e4c 100644
---
a/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/SignatureConfirmationTest.java
+++
b/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/SignatureConfirmationTest.java
@@ -91,7 +91,7 @@ public class SignatureConfirmationTest extends
AbstractSecurityTest {
//
Set<Integer> sigv =
CastUtils.cast((Set<?>)msg.get(WSHandlerConstants.SEND_SIGV));
assertNotNull(sigv);
- assertTrue(sigv.size() != 0);
+ assertTrue(!sigv.isEmpty());
XMLStreamReader reader = StaxUtils.createXMLStreamReader(new
ByteArrayInputStream(docbytes));
@@ -125,7 +125,7 @@ public class SignatureConfirmationTest extends
AbstractSecurityTest {
List<WSHandlerResult> sigReceived =
CastUtils.cast((List<?>)inmsg.get(WSHandlerConstants.RECV_RESULTS));
assertNotNull(sigReceived);
- assertTrue(sigReceived.size() != 0);
+ assertTrue(!sigReceived.isEmpty());
testSignatureConfirmationResponse(sigv, sigReceived);
}
diff --git
a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
index 4c66649..81e2ea3 100644
---
a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
+++
b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
@@ -1554,7 +1554,7 @@ public class ReflectionServiceFactoryBean extends
org.apache.cxf.service.factory
initializeParameter(part, paramClasses[j], genParTypes[j]);
part.setProperty(METHOD_PARAM_ANNOTATIONS, parAnnotations);
part.setProperty(PARAM_ANNOTATION, parAnnotations[j]);
- if (getJaxbAnnoMap(part).size() > 0) {
+ if (!getJaxbAnnoMap(part).isEmpty()) {
op.setProperty(WRAPPERGEN_NEEDED, true);
}
if (!isWrapped(method) && !isRPC(method)) {
diff --git
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/claims/LdapGroupClaimsHandler.java
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/claims/LdapGroupClaimsHandler.java
index 43c797b..1e7af1f 100644
---
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/claims/LdapGroupClaimsHandler.java
+++
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/claims/LdapGroupClaimsHandler.java
@@ -249,7 +249,7 @@ public class LdapGroupClaimsHandler implements
ClaimsHandler, RealmSupport {
}
String scope = null;
- if (getAppliesToScopeMapping() != null &&
getAppliesToScopeMapping().size() > 0
+ if (getAppliesToScopeMapping() != null &&
!getAppliesToScopeMapping().isEmpty()
&& parameters.getAppliesToAddress() != null) {
scope =
getAppliesToScopeMapping().get(parameters.getAppliesToAddress());
if (LOG.isLoggable(Level.FINE)) {
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlOperation.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlOperation.java
index c5be148..50a518d 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlOperation.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlOperation.java
@@ -74,7 +74,7 @@ public final class IdlOperation extends IdlScopeBase {
Collection<IdlDefn> defns = definitions();
- if (defns.size() != 0) {
+ if (!defns.isEmpty()) {
pw.println();
indentMore();
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToIDLAction.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToIDLAction.java
index 6f4d690..7484cd4 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToIDLAction.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToIDLAction.java
@@ -768,7 +768,7 @@ public class WSDLToIDLAction {
}
}
} else {
- if (bindings.size() >= 1) {
+ if (!bindings.isEmpty()) {
binding = bindings.iterator().next();
}
}
diff --git
a/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
b/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
index de65803..139e8ae 100644
---
a/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
+++
b/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
@@ -716,7 +716,7 @@ public class SourceGenerator {
List<Element> responseEls = getWadlElements(methodEl, "response");
List<Element> requestEls = getWadlElements(methodEl, "request");
- Element firstRequestEl = requestEls.size() >= 1 ? requestEls.get(0) :
null;
+ Element firstRequestEl = !requestEls.isEmpty() ? requestEls.get(0) :
null;
List<Element> allRequestReps = getWadlElements(firstRequestEl,
"representation");
List<Element> requestRepsWithElements = new LinkedList<>();
boolean duplicatesAvailable =
diff --git
a/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
b/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
index 6bf1e06..d9e06a2 100644
---
a/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
+++
b/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
@@ -897,7 +897,7 @@ public class JAXBDataBinding implements DataBindingProfile {
ToolConstants.SCHEMA_URI,
"include");
boolean hasJAXB = DOMUtils.hasElementInNS(element,
ToolConstants.NS_JAXB_BINDINGS);
- if (impElemList.isEmpty() && incElemList.size() == 0 && !hasJAXB) {
+ if (impElemList.isEmpty() && incElemList.isEmpty() && !hasJAXB) {
return element;
}
element = (Element)cloneNode(element.getOwnerDocument(), element,
true);
