This is an automated email from the ASF dual-hosted git repository.
coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cxf.git
The following commit(s) were added to refs/heads/master by this push:
new 498129c Using append instead of string concatentation
498129c is described below
commit 498129c6d5b4545e67a7d671f51a54c2e1156928
Author: Colm O hEigeartaigh <[email protected]>
AuthorDate: Tue Mar 12 12:56:46 2019 +0000
Using append instead of string concatentation
---
.../bus/managers/WorkQueueImplMBeanWrapper.java | 2 +-
.../java/org/apache/cxf/common/util/Compiler.java | 4 +--
.../org/apache/cxf/common/util/PackageUtils.java | 2 +-
.../java/org/apache/cxf/helpers/FileUtils.java | 2 +-
.../apache/cxf/jca/outbound/CXFConnectionSpec.java | 12 ++++----
.../metrics/codahale/CodahaleMetricsProvider.java | 2 +-
.../validation/JAXRSParameterNameProvider.java | 4 +--
.../org/apache/cxf/javascript/JavascriptUtils.java | 8 +++---
.../service/ServiceJavascriptBuilder.java | 2 +-
.../javascript/types/SchemaJavascriptBuilder.java | 4 +--
.../AbstractMessageResponseTimeInterceptor.java | 18 ++++++------
.../cxf/management/utils/ManagementConsole.java | 2 +-
.../cxf/management/jmx/BusRegistrationTest.java | 8 +++---
.../apache/cxf/jaxrs/ext/search/SearchUtils.java | 2 +-
.../jaxrs/ext/search/sql/SQLPrinterVisitor.java | 6 ++--
.../cxf/rs/security/jose/jws/JwsJsonProducer.java | 2 +-
.../security/jose/jws/JwsJsonSignatureEntry.java | 6 ++--
.../transport/servlet/ServletControllerTest.java | 4 +--
.../apache/cxf/transport/jms/uri/JMSEndpoint.java | 6 ++--
.../apache/cxf/sts/cache/EHCacheIdentityCache.java | 2 +-
.../apache/cxf/sts/cache/MemoryIdentityCache.java | 2 +-
.../sts/cache/MemoryIdentityCacheStatistics.java | 2 +-
.../apache/cxf/systest/jaxrs/JAXRSUriInfoTest.java | 2 +-
.../corba/common/idltypes/IdlAnonSequence.java | 4 +--
.../tools/corba/processors/idl/ConstVisitor.java | 2 +-
.../corba/processors/idl/IDLToWSDLProcessor.java | 2 +-
.../corba/processors/idl/PortTypeVisitor.java | 3 +-
.../cxf/tools/corba/processors/idl/Scope.java | 2 +-
.../cxf/tools/corba/processors/idl/TypesUtils.java | 2 +-
.../tools/corba/utils/FileOutputStreamFactory.java | 2 +-
.../cxf/tools/wadlto/jaxrs/SourceGenerator.java | 32 +++++++++++-----------
.../wsdlto/databinding/jaxb/JAXBDataBinding.java | 2 +-
32 files changed, 78 insertions(+), 77 deletions(-)
diff --git
a/core/src/main/java/org/apache/cxf/bus/managers/WorkQueueImplMBeanWrapper.java
b/core/src/main/java/org/apache/cxf/bus/managers/WorkQueueImplMBeanWrapper.java
index 1e0e3e8..1c588cb 100644
---
a/core/src/main/java/org/apache/cxf/bus/managers/WorkQueueImplMBeanWrapper.java
+++
b/core/src/main/java/org/apache/cxf/bus/managers/WorkQueueImplMBeanWrapper.java
@@ -116,7 +116,7 @@ public class WorkQueueImplMBeanWrapper implements
ManagedComponent {
buffer.append(WorkQueueManagerImplMBeanWrapper.NAME_VALUE).append(',');
} else {
buffer.append(ManagementConstants.BUS_ID_PROP).append("=Shared,");
- //buffer.append(WorkQueueManagerImplMBeanWrapper.TYPE_VALUE +
"=Shared,");
+
//buffer.append(WorkQueueManagerImplMBeanWrapper.TYPE_VALUE).append("=Shared,");
}
buffer.append(ManagementConstants.TYPE_PROP).append('=').append(TYPE_VALUE).append(',');
buffer.append(ManagementConstants.NAME_PROP).append('=').append(aWorkQueue.getName()).append(',');
diff --git a/core/src/main/java/org/apache/cxf/common/util/Compiler.java
b/core/src/main/java/org/apache/cxf/common/util/Compiler.java
index d555a77..3c5bc4c 100644
--- a/core/src/main/java/org/apache/cxf/common/util/Compiler.java
+++ b/core/src/main/java/org/apache/cxf/common/util/Compiler.java
@@ -329,11 +329,11 @@ public class Compiler {
for (int i = 0; i < args.length; i++) {
strBuffer.append(args[i]);
}
- return strBuffer.toString().length() > 4096 ? true : false;
+ return strBuffer.length() > 4096;
}
private boolean isLongClasspath(String classpath) {
- return classpath.length() > 2048 ? true : false;
+ return classpath.length() > 2048;
}
private void checkLongClasspath(String classpath, List<String> list, int
classpathIdx) {
diff --git a/core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
b/core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
index 50b08a4..ffe6483 100644
--- a/core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
+++ b/core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
@@ -168,7 +168,7 @@ public final class PackageUtils {
if (i == 0 && !Character.isJavaIdentifierStart(c)) {
// prefix an '_' if the first char is illegal
- newToken.append("_" + c);
+ newToken.append("_").append(c);
} else if (!Character.isJavaIdentifierPart(c)) {
// replace the char with an '_' if it is illegal
newToken.append('_');
diff --git a/core/src/main/java/org/apache/cxf/helpers/FileUtils.java
b/core/src/main/java/org/apache/cxf/helpers/FileUtils.java
index 6d21442..963b9b5 100644
--- a/core/src/main/java/org/apache/cxf/helpers/FileUtils.java
+++ b/core/src/main/java/org/apache/cxf/helpers/FileUtils.java
@@ -327,7 +327,7 @@ public final class FileUtils {
for (int x = 0; x < tok.length; x++) {
String token = tok[x];
- result.append(" " + token);
+ result.append(" ").append(token);
}
line = in.readLine();
}
diff --git
a/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
b/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
index 89e6730..f69fd89 100644
---
a/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
+++
b/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
@@ -181,12 +181,12 @@ public class CXFConnectionSpec implements
ConnectionRequestInfo {
public String toString() {
StringBuilder buf = new StringBuilder();
- buf.append("serviceName=" + serviceName);
- buf.append(",endpointName=" + endpointName);
- buf.append(",wsdlURL=" + wsdlURL);
- buf.append(",busConfigURL=" + busConfigURL);
- buf.append(",serviceClass=" + serviceClass);
- buf.append(",address=" + address);
+ buf.append("serviceName=").append(serviceName);
+ buf.append(",endpointName=").append(endpointName);
+ buf.append(",wsdlURL=").append(wsdlURL);
+ buf.append(",busConfigURL=").append(busConfigURL);
+ buf.append(",serviceClass=").append(serviceClass);
+ buf.append(",address=").append(address);
return buf.toString();
}
diff --git
a/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsProvider.java
b/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsProvider.java
index fd5187f..2b0d684 100644
---
a/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsProvider.java
+++
b/rt/features/metrics/src/main/java/org/apache/cxf/metrics/codahale/CodahaleMetricsProvider.java
@@ -98,7 +98,7 @@ public class CodahaleMetricsProvider implements
MetricsProvider {
String serviceName = "\"" +
escapePatternChars(service.getName().toString()) + "\"";
String portName = "\"" +
endpoint.getEndpointInfo().getName().getLocalPart() + "\"";
- buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME + ":");
+ buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME).append(":");
buffer.append(ManagementConstants.BUS_ID_PROP + "=" + bus.getId()
+ ",");
buffer.append(ManagementConstants.TYPE_PROP).append("=Metrics");
if (isClient) {
diff --git
a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/validation/JAXRSParameterNameProvider.java
b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/validation/JAXRSParameterNameProvider.java
index f1a3d44..3454a35 100644
---
a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/validation/JAXRSParameterNameProvider.java
+++
b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/validation/JAXRSParameterNameProvider.java
@@ -47,13 +47,13 @@ public class JAXRSParameterNameProvider implements
ParameterNameProvider {
for (int i = 0; i < parameters.size(); ++i) {
final StringBuilder sb = new StringBuilder();
- sb.append("arg" + i);
+ sb.append("arg").append(i);
sb.append('(');
Parameter parameter = parameters.get(i);
if (parameter.getName() != null) {
sb.append(parameter.getType().toString());
- sb.append("(\"" + parameter.getName() + "\")");
+ sb.append("(\"").append(parameter.getName()).append("\")");
sb.append(' ');
}
sb.append(method.getParameterTypes()[i].getSimpleName());
diff --git
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/JavascriptUtils.java
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/JavascriptUtils.java
index 7917ab5..099406f 100755
---
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/JavascriptUtils.java
+++
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/JavascriptUtils.java
@@ -157,14 +157,14 @@ public class JavascriptUtils {
code.append(prefix());
code.append(xmlStringAccumulatorVariable + " = " +
xmlStringAccumulatorVariable + " + '");
code.append(escapeStringQuotes(value));
- code.append("';" + NL);
+ code.append("';").append(NL);
}
public void appendExpression(String value) {
code.append(prefix());
code.append(xmlStringAccumulatorVariable + " = " +
xmlStringAccumulatorVariable + " + ");
code.append(value);
- code.append(";" + NL);
+ code.append(";").append(NL);
}
private String prefix() {
@@ -185,7 +185,7 @@ public class JavascriptUtils {
public void startBlock() {
code.append(prefix());
- code.append("{" + NL);
+ code.append("{").append(NL);
prefixStack.push(prefix() + " ");
}
@@ -199,7 +199,7 @@ public class JavascriptUtils {
public void endBlock() {
prefixStack.pop();
code.append(prefix());
- code.append("}" + NL);
+ code.append("}").append(NL);
}
public void startFor(String start, String test, String increment) {
diff --git
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/service/ServiceJavascriptBuilder.java
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/service/ServiceJavascriptBuilder.java
index ed18f45..38d6577 100755
---
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/service/ServiceJavascriptBuilder.java
+++
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/service/ServiceJavascriptBuilder.java
@@ -331,7 +331,7 @@ public class ServiceJavascriptBuilder extends
ServiceModelVisitor {
code.append("// - Object constructor is "
+ nameManager.getJavascriptName(baseName)
+ "\n");
} else if (type != null) {
- code.append("// - simple type " + type.getQName());
+ code.append("// - simple type ").append(type.getQName());
}
}
}
diff --git
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/types/SchemaJavascriptBuilder.java
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/types/SchemaJavascriptBuilder.java
index 33f87bf..b0604d1 100755
---
a/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/types/SchemaJavascriptBuilder.java
+++
b/rt/javascript/javascript-rt/src/main/java/org/apache/cxf/javascript/types/SchemaJavascriptBuilder.java
@@ -91,9 +91,9 @@ public class SchemaJavascriptBuilder {
xmlSchema = schema;
code = new StringBuilder();
code.append("//\n");
- code.append("// Definitions for schema: " +
schema.getTargetNamespace());
+ code.append("// Definitions for schema:
").append(schema.getTargetNamespace());
if (schema.getSourceURI() != null) {
- code.append("\n// " + schema.getSourceURI());
+ code.append("\n// ").append(schema.getSourceURI());
}
code.append("\n//\n");
diff --git
a/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
b/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
index 4289f05..f7b74ac 100644
---
a/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
+++
b/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
@@ -128,19 +128,19 @@ public abstract class
AbstractMessageResponseTimeInterceptor extends AbstractPha
String serviceName = "\"" +
escapePatternChars(service.getName().toString()) + "\"";
String portName = "\"" +
endpoint.getEndpointInfo().getName().getLocalPart() + "\"";
- buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME + ":");
- buffer.append(ManagementConstants.BUS_ID_PROP + "=" +
bus.getId() + ",");
+
buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME).append(":");
+
buffer.append(ManagementConstants.BUS_ID_PROP).append("=").append(bus.getId()).append(",");
Message message = ex.getOutMessage();
if (isClient(message)) {
- buffer.append(ManagementConstants.TYPE_PROP + "=" +
Counter.PERFORMANCE_COUNTER
- + ".Client,");
+ buffer.append(ManagementConstants.TYPE_PROP).append("=")
+
.append(Counter.PERFORMANCE_COUNTER).append(".Client,");
} else {
- buffer.append(ManagementConstants.TYPE_PROP + "=" +
Counter.PERFORMANCE_COUNTER
- + ".Server,");
+ buffer.append(ManagementConstants.TYPE_PROP).append("=")
+
.append(Counter.PERFORMANCE_COUNTER).append(".Server,");
}
- buffer.append(ManagementConstants.SERVICE_NAME_PROP + "=" +
serviceName + ",");
+
buffer.append(ManagementConstants.SERVICE_NAME_PROP).append("=").append(serviceName).append(",");
- buffer.append(ManagementConstants.PORT_NAME_PROP + "=" +
portName);
+
buffer.append(ManagementConstants.PORT_NAME_PROP).append("=").append(portName);
try {
serviceCounterName = new ObjectName(buffer.toString());
@@ -185,7 +185,7 @@ public abstract class
AbstractMessageResponseTimeInterceptor extends AbstractPha
}
StringBuilder buffer = new StringBuilder(sericeCounterName.toString());
if (operationName != null) {
- buffer.append("," + ManagementConstants.OPERATION_NAME_PROP + "="
+ operationName);
+
buffer.append(",").append(ManagementConstants.OPERATION_NAME_PROP).append("=").append(operationName);
}
String operationCounterName = buffer.toString();
ObjectName operationCounter = null;
diff --git
a/rt/management/src/main/java/org/apache/cxf/management/utils/ManagementConsole.java
b/rt/management/src/main/java/org/apache/cxf/management/utils/ManagementConsole.java
index 41f7908..2e4e342 100644
---
a/rt/management/src/main/java/org/apache/cxf/management/utils/ManagementConsole.java
+++
b/rt/management/src/main/java/org/apache/cxf/management/utils/ManagementConsole.java
@@ -103,7 +103,7 @@ public final class ManagementConsole {
ObjectName getEndpointObjectName()
throws MalformedObjectNameException, NullPointerException {
StringBuilder buffer = new StringBuilder();
- buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME +
":type=Bus.Service.Endpoint,");
+
buffer.append(ManagementConstants.DEFAULT_DOMAIN_NAME).append(":type=Bus.Service.Endpoint,");
buffer.append(ManagementConstants.SERVICE_NAME_PROP + "=\"" +
serviceName + "\",");
buffer.append(ManagementConstants.PORT_NAME_PROP + "=\"" + portName +
"\",*");
return new ObjectName(buffer.toString());
diff --git
a/rt/management/src/test/java/org/apache/cxf/management/jmx/BusRegistrationTest.java
b/rt/management/src/test/java/org/apache/cxf/management/jmx/BusRegistrationTest.java
index c1c038f..16946df 100644
---
a/rt/management/src/test/java/org/apache/cxf/management/jmx/BusRegistrationTest.java
+++
b/rt/management/src/test/java/org/apache/cxf/management/jmx/BusRegistrationTest.java
@@ -136,10 +136,10 @@ public class BusRegistrationTest {
private static ObjectName getObjectName(String id, Bus bus) throws
JMException {
StringBuilder buffer = new
StringBuilder(ManagementConstants.DEFAULT_DOMAIN_NAME + ":");
- buffer.append(ManagementConstants.BUS_ID_PROP + "=" + id + ",");
- buffer.append(ManagementConstants.TYPE_PROP + "=Bus,");
+
buffer.append(ManagementConstants.BUS_ID_PROP).append("=").append(id).append(",");
+ buffer.append(ManagementConstants.TYPE_PROP).append("=Bus,");
// Added the instance id to make the ObjectName unique
- buffer.append(ManagementConstants.INSTANCE_ID_PROP + "=" +
bus.hashCode());
+
buffer.append(ManagementConstants.INSTANCE_ID_PROP).append("=").append(bus.hashCode());
return new ObjectName(buffer.toString());
}
-}
\ No newline at end of file
+}
diff --git
a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/SearchUtils.java
b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/SearchUtils.java
index b36c20b..2ee4be4 100644
---
a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/SearchUtils.java
+++
b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/SearchUtils.java
@@ -156,7 +156,7 @@ public final class SearchUtils {
}
sb.append(" FROM ").append(table);
if (tableAlias != null) {
- sb.append(" " + tableAlias);
+ sb.append(" ").append(tableAlias);
}
}
diff --git
a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/sql/SQLPrinterVisitor.java
b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/sql/SQLPrinterVisitor.java
index 680435e..9033278 100644
---
a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/sql/SQLPrinterVisitor.java
+++
b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/sql/SQLPrinterVisitor.java
@@ -88,9 +88,9 @@ public class SQLPrinterVisitor<T> extends
AbstractUntypedSearchConditionVisitor<
}
joiningKey += "_id";
- topBuilder.append(" left join " + joinTable);
- topBuilder.append(" on " + primaryTable + ".id" + " = " +
joinTable
- + "." + joiningKey);
+ topBuilder.append(" left join ").append(joinTable);
+ topBuilder.append(" on
").append(primaryTable).append(".id").append(" = ")
+ .append(joinTable).append(".").append(joiningKey);
property = joinTable + "." +
getRealPropertyName(properties[1]);
}
diff --git
a/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonProducer.java
b/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonProducer.java
index 9310893..f8fb5c7 100644
---
a/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonProducer.java
+++
b/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonProducer.java
@@ -81,7 +81,7 @@ public class JwsJsonProducer {
StringBuilder sb = new StringBuilder();
sb.append('{');
if (!detached) {
- sb.append("\"payload\":\"" + getActualPayload(b64Status) + "\"");
+
sb.append("\"payload\":\"").append(getActualPayload(b64Status)).append("\"");
sb.append(',');
}
if (!supportFlattened || signatures.size() > 1) {
diff --git
a/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonSignatureEntry.java
b/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonSignatureEntry.java
index 43c543e..19e6241 100644
---
a/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonSignatureEntry.java
+++
b/rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jws/JwsJsonSignatureEntry.java
@@ -144,16 +144,16 @@ public class JwsJsonSignatureEntry implements JsonObject {
sb.append('{');
}
if (protectedHeader != null) {
- sb.append("\"protected\":\"" +
Base64UrlUtility.encode(writer.toJson(protectedHeader)) + "\"");
+
sb.append("\"protected\":\"").append(Base64UrlUtility.encode(writer.toJson(protectedHeader))).append("\"");
}
if (unprotectedHeader != null) {
if (protectedHeader != null) {
sb.append(',');
}
- sb.append("\"header\":" + writer.toJson(unprotectedHeader));
+ sb.append("\"header\":").append(writer.toJson(unprotectedHeader));
}
sb.append(',');
- sb.append("\"signature\":\"" + encodedSignature + "\"");
+ sb.append("\"signature\":\"").append(encodedSignature).append("\"");
if (!flattenedMode) {
sb.append('}');
}
diff --git
a/rt/transports/http/src/test/java/org/apache/cxf/transport/servlet/ServletControllerTest.java
b/rt/transports/http/src/test/java/org/apache/cxf/transport/servlet/ServletControllerTest.java
index a957f89..3c97991 100644
---
a/rt/transports/http/src/test/java/org/apache/cxf/transport/servlet/ServletControllerTest.java
+++
b/rt/transports/http/src/test/java/org/apache/cxf/transport/servlet/ServletControllerTest.java
@@ -69,7 +69,7 @@ public class ServletControllerTest {
req.getParameter("formatted");
EasyMock.expectLastCall().andReturn(formatted);
req.getRequestURL();
- EasyMock.expectLastCall().andReturn(new
StringBuffer("http://localhost:8080"; + requestUri));
+ EasyMock.expectLastCall().andReturn(new
StringBuffer("http://localhost:8080"; + requestUri)); //NOPMD
registry.getDestinationsPaths();
EasyMock.expectLastCall().andReturn(Collections.emptySet()).atLeastOnce();
registry.getDestinationForPath("", true);
@@ -188,4 +188,4 @@ public class ServletControllerTest {
return invokeDestinationCalled;
}
}
-}
\ No newline at end of file
+}
diff --git
a/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/uri/JMSEndpoint.java
b/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/uri/JMSEndpoint.java
index 1bf0f66..6d2a72f 100644
---
a/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/uri/JMSEndpoint.java
+++
b/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/uri/JMSEndpoint.java
@@ -211,15 +211,15 @@ public class JMSEndpoint {
} else {
requestUri.append(jmsVariant);
}
- requestUri.append(":" + destinationName);
+ requestUri.append(":").append(destinationName);
boolean first = true;
for (Map.Entry<String, String> entry : parameters.entrySet()) {
String value = entry.getValue();
if (first) {
- requestUri.append("?" + entry.getKey() + "=" + value);
+
requestUri.append("?").append(entry.getKey()).append("=").append(value);
first = false;
} else {
- requestUri.append("&" + entry.getKey() + "=" + value);
+
requestUri.append("&").append(entry.getKey()).append("=").append(value);
}
}
return requestUri.toString();
diff --git
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/EHCacheIdentityCache.java
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/EHCacheIdentityCache.java
index 4d1e643..c4945f4 100644
---
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/EHCacheIdentityCache.java
+++
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/EHCacheIdentityCache.java
@@ -190,7 +190,7 @@ public class EHCacheIdentityCache extends
AbstractIdentityCache
}
buffer.append(ManagementConstants.TYPE_PROP).append('=').append("EHCacheIdentityCache").append(',');
buffer.append(ManagementConstants.NAME_PROP).append('=')
- .append("EHCacheIdentityCache-" + System.identityHashCode(this));
+
.append("EHCacheIdentityCache-").append(System.identityHashCode(this));
return new ObjectName(buffer.toString());
}
}
diff --git
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCache.java
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCache.java
index 40d2f64..fabfc4c 100644
---
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCache.java
+++
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCache.java
@@ -125,7 +125,7 @@ public class MemoryIdentityCache extends
AbstractIdentityCache {
}
buffer.append(ManagementConstants.TYPE_PROP).append('=').append("MemoryIdentityCache").append(',');
buffer.append(ManagementConstants.NAME_PROP).append('=')
- .append("MemoryIdentityCache-" + System.identityHashCode(this));
+
.append("MemoryIdentityCache-").append(System.identityHashCode(this));
return new ObjectName(buffer.toString());
}
}
diff --git
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCacheStatistics.java
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCacheStatistics.java
index aca0e90..688c53d 100644
---
a/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCacheStatistics.java
+++
b/services/sts/sts-core/src/main/java/org/apache/cxf/sts/cache/MemoryIdentityCacheStatistics.java
@@ -58,7 +58,7 @@ public class MemoryIdentityCacheStatistics implements
ManagedComponent {
.append(ManagementConstants.TYPE_PROP).append('=')
.append("MemoryIdentityCacheStatistics").append(',')
.append(ManagementConstants.NAME_PROP).append('=')
- .append("MemoryIdentityCacheStatistics-" +
System.identityHashCode(this));
+
.append("MemoryIdentityCacheStatistics-").append(System.identityHashCode(this));
objectName = new ObjectName(buffer.toString());
im.register(this);
diff --git
a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSUriInfoTest.java
b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSUriInfoTest.java
index 6272e17..6f8b56f 100644
---
a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSUriInfoTest.java
+++
b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSUriInfoTest.java
@@ -120,7 +120,7 @@ public class JAXRSUriInfoTest extends
AbstractClientServerTestBase {
StringBuilder sb = new StringBuilder();
sb.append(uriInfo.getBaseUri());
sb.append(",\"" + path + "\"");
- sb.append("," + uriInfo.getPath());
+ sb.append(",").append(uriInfo.getPath());
return sb.toString();
}
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlAnonSequence.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlAnonSequence.java
index 96681f2..828b18d 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlAnonSequence.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/IdlAnonSequence.java
@@ -53,12 +53,12 @@ public final class IdlAnonSequence extends IdlSequenceBase {
private String seqName(String name) {
StringBuilder str = new StringBuilder();
- str.append("sequence<" + name);
+ str.append("sequence<").append(name);
int bnd = bound();
if (bnd != 0) {
- str.append(", " + bnd);
+ str.append(", ").append(bnd);
}
str.append("> ");
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/ConstVisitor.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/ConstVisitor.java
index 7ab64d2..299e0b0 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/ConstVisitor.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/ConstVisitor.java
@@ -71,7 +71,7 @@ public class ConstVisitor extends VisitorBase {
if (ch >= 0 && ch <= 31) {
// ascii code between 0 and 31 is invisible control code
constValue.deleteCharAt(0);
- constValue.append("\\" + Integer.toOctalString(ch));
+ constValue.append("\\").append(Integer.toOctalString(ch));
}
}
while (constValueNode != null) {
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/IDLToWSDLProcessor.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/IDLToWSDLProcessor.java
index e380589..a465b5d 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/IDLToWSDLProcessor.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/IDLToWSDLProcessor.java
@@ -435,7 +435,7 @@ public class IDLToWSDLProcessor extends IDLProcessor {
if (bindingTokens.length > 1) {
StringBuilder name = new StringBuilder("");
for (int j = 0; j < bindingTokens.length - 2; j++) {
- name.append(bindingTokens[j] + ".");
+ name.append(bindingTokens[j]).append(".");
}
name.append(bindingTokens[bindingTokens.length - 2] +
"CORBAService");
serviceNames.put(ns, name.toString());
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/PortTypeVisitor.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/PortTypeVisitor.java
index 5e9be17..18cef1b 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/PortTypeVisitor.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/PortTypeVisitor.java
@@ -230,7 +230,8 @@ public class PortTypeVisitor extends VisitorBase {
public Binding createBinding(String scopedPortTypeName) {
- StringBuilder bname = new StringBuilder(scopedPortTypeName +
"CORBABinding");
+ StringBuilder bname = new StringBuilder();
+ bname.append(scopedPortTypeName).append("CORBABinding");
QName bqname = new QName(rootDefinition.getTargetNamespace(),
bname.toString());
int count = 0;
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/Scope.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/Scope.java
index f35b738..f8f14c9 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/Scope.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/Scope.java
@@ -116,7 +116,7 @@ public final class Scope implements Comparable<Object> {
StringBuilder result = new StringBuilder();
result.append(CorbaConstants.REPO_STRING);
if (prefix != null && prefix.length() > 0) {
- result.append(prefix + "/");
+ result.append(prefix).append("/");
}
result.append(toString("/"));
result.append(CorbaConstants.IDL_VERSION);
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/TypesUtils.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/TypesUtils.java
index a78260e..21b0d1b 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/TypesUtils.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/TypesUtils.java
@@ -91,7 +91,7 @@ public final class TypesUtils {
id++;
StringBuilder name = new StringBuilder();
name.append('_');
- name.append("Anon" + id.toString());
+ name.append("Anon").append(id.toString());
name.append('_');
name.append(scope.tail());
scopedName = new Scope(scope.getParent(), name.toString());
diff --git
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/utils/FileOutputStreamFactory.java
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/utils/FileOutputStreamFactory.java
index 55f2bd7..9fff88c 100644
---
a/tools/corba/src/main/java/org/apache/cxf/tools/corba/utils/FileOutputStreamFactory.java
+++
b/tools/corba/src/main/java/org/apache/cxf/tools/corba/utils/FileOutputStreamFactory.java
@@ -99,7 +99,7 @@ public class FileOutputStreamFactory implements
OutputStreamFactory {
StringBuilder result = new StringBuilder("");
while (pos2 != -1) {
- result.append(packageName.substring(pos1, pos2) + File.separator);
+ result.append(packageName.substring(pos1,
pos2)).append(File.separator);
pos1 = pos2 + 1;
pos2 = packageName.indexOf('.', pos1);
}
diff --git
a/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
b/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
index 321803a..7b5c0ee 100644
---
a/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
+++
b/tools/wadlto/jaxrs/src/main/java/org/apache/cxf/tools/wadlto/jaxrs/SourceGenerator.java
@@ -469,7 +469,7 @@ public class SourceGenerator {
StringBuilder builder = new StringBuilder(resourceId);
for (int i = 0; i < split.length; i++) {
if (split[i].length() > 0) {
- builder.append(split[i].toUpperCase().charAt(0) +
split[i].substring(1));
+
builder.append(split[i].toUpperCase().charAt(0)).append(split[i].substring(1));
}
}
resourceId = builder.toString();
@@ -501,7 +501,7 @@ public class SourceGenerator {
sbImports.append(getClassComment()).append(getLineSep());
- sbImports.append("package " + classPackage)
+ sbImports.append("package ").append(classPackage)
.append(';').append(getLineSep()).append(getLineSep());
boolean doCreateJavaDocs = isJavaDocNeeded(info);
if (doCreateJavaDocs) {
@@ -512,9 +512,9 @@ public class SourceGenerator {
writeAnnotation(sbCode, imports, Path.class, path, true, false);
}
- sbCode.append("public " + getClassType(info.interfaceIsGenerated) + "
" + className);
+ sbCode.append("public
").append(getClassType(info.interfaceIsGenerated)).append("
").append(className);
writeImplementsInterface(sbCode, qname.getLocalPart(),
info.isInterfaceGenerated());
- sbCode.append(" {" + getLineSep() + getLineSep());
+ sbCode.append(" {").append(getLineSep()).append(getLineSep());
Map<String, Integer> methodNameMap = new HashMap<>();
writeMethods(rElement, classPackage, imports, sbCode,
@@ -604,7 +604,7 @@ public class SourceGenerator {
private void writeImplementsInterface(StringBuilder sb, String clsName,
boolean interfaceIsGenerated) {
if (generateInterfaces && !interfaceIsGenerated) {
- sb.append(" implements " + StringUtils.capitalize(clsName));
+ sb.append(" implements ").append(StringUtils.capitalize(clsName));
}
}
@@ -661,7 +661,7 @@ public class SourceGenerator {
addImport(imports, cls.getName());
sbCode.append('@').append(cls.getSimpleName());
if (value != null) {
- sbCode.append("(\"" + value + "\")");
+ sbCode.append("(\"").append(value).append("\")");
}
if (nextLine) {
sbCode.append(getLineSep());
@@ -686,7 +686,7 @@ public class SourceGenerator {
if (index != -1 && clsName.substring(0,
index).equals(classPackage)) {
continue;
}
- sbImports.append("import " +
clsName).append(';').append(getLineSep());
+ sbImports.append("import
").append(clsName).append(';').append(getLineSep());
}
}
@@ -957,7 +957,7 @@ public class SourceGenerator {
StringBuilder sbMethodClassImports = new StringBuilder();
sbMethodClassImports.append(getClassComment()).append(getLineSep());
- sbMethodClassImports.append("package " + classPackage)
+ sbMethodClassImports.append("package ").append(classPackage)
.append(';').append(getLineSep()).append(getLineSep());
sbMethodClassImports.append("import
java.lang.annotation.ElementType;").append(getLineSep());
@@ -969,9 +969,9 @@ public class SourceGenerator {
StringBuilder sbMethodClassCode = new StringBuilder();
sbMethodClassCode.append("@Target({ElementType.METHOD
})").append(getLineSep());
sbMethodClassCode.append("@Retention(RetentionPolicy.RUNTIME)").append(getLineSep());
- sbMethodClassCode.append("@HttpMethod(\"" + methodName +
"\")").append(getLineSep());
- sbMethodClassCode.append("public @interface " + methodName);
- sbMethodClassCode.append(" {" + getLineSep() + getLineSep());
+
sbMethodClassCode.append("@HttpMethod(\"").append(methodName).append("\")").append(getLineSep());
+ sbMethodClassCode.append("public @interface ").append(methodName);
+ sbMethodClassCode.append("
{").append(getLineSep()).append(getLineSep());
sbMethodClassCode.append('}');
createJavaSourceFile(info.getSrcDir(), new QName(classPackage,
className),
sbMethodClassCode, sbMethodClassImports, true);
@@ -1002,7 +1002,7 @@ public class SourceGenerator {
writeSubResponseType(id.equals(parentId), subResponseNs, localName,
sbCode, imports);
- sbCode.append("get" + localName + suffixName);
+ sbCode.append("get").append(localName).append(suffixName);
}
private static boolean isMethodMatched(Set<String> methodNames, String
methodNameLowerCase, String id) {
@@ -1201,7 +1201,7 @@ public class SourceGenerator {
info, imports, true);
}
if (elementType != null) {
- sbCode.append(elementType + " ");
+ sbCode.append(elementType).append(" ");
} else {
writeJaxrResponse(sbCode, imports);
}
@@ -1432,10 +1432,10 @@ public class SourceGenerator {
StringBuilder sbImports = new StringBuilder();
StringBuilder sbCode = new StringBuilder();
sbImports.append(getClassComment()).append(getLineSep());
- sbImports.append("package " + classPackage)
+ sbImports.append("package ").append(classPackage)
.append(';').append(getLineSep()).append(getLineSep());
- sbCode.append("public enum " + clsName);
+ sbCode.append("public enum ").append(clsName);
openBlock(sbCode);
for (int i = 0; i < options.size(); i++) {
@@ -1728,7 +1728,7 @@ public class SourceGenerator {
mediaTypes.append(", ");
}
first = false;
- mediaTypes.append("\"" + mediaType + "\"");
+ mediaTypes.append("\"").append(mediaType).append("\"");
}
}
sbCode.append(mediaTypes.toString());
diff --git
a/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
b/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
index d9e06a2..fee76bd 100644
---
a/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
+++
b/tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
@@ -411,7 +411,7 @@ public class JAXBDataBinding implements DataBindingProfile {
} catch (BadCommandLineException e) {
StringBuilder msg = new StringBuilder("XJC reported
'BadCommandLineException' for -xjc argument:");
for (String arg : args) {
- msg.append(arg + " ");
+ msg.append(arg).append(" ");
}
LOG.log(Level.FINE, msg.toString(), e);
if (opts != null) {
