This is an automated email from the ASF dual-hosted git repository.

coheigea pushed a commit to branch 1.4.x-fixes
in repository https://gitbox.apache.org/repos/asf/cxf-fediz.git


The following commit(s) were added to refs/heads/1.4.x-fixes by this push:
     new 3d5fb50  Removing hard-coded password
3d5fb50 is described below

commit 3d5fb501a7d944257a1c52297941f94bb6d9a412
Author: Colm O hEigeartaigh <[email protected]>
AuthorDate: Wed Jul 3 13:11:19 2019 +0100

    Removing hard-coded password
---
 .../apache/cxf/fediz/service/oidc/PrivateKeyPasswordProviderImpl.java | 2 +-
 services/oidc/src/main/webapp/WEB-INF/applicationContext.xml          | 4 +++-
 systests/oidc/src/test/resources/oidc/applicationContext.xml          | 4 +++-
 systests/oidc/src/test/resources/oidc/spring/applicationContext.xml   | 4 +++-
 4 files changed, 10 insertions(+), 4 deletions(-)

diff --git 
a/services/oidc/src/main/java/org/apache/cxf/fediz/service/oidc/PrivateKeyPasswordProviderImpl.java
 
b/services/oidc/src/main/java/org/apache/cxf/fediz/service/oidc/PrivateKeyPasswordProviderImpl.java
index 98ff23e..9ad8a2d 100644
--- 
a/services/oidc/src/main/java/org/apache/cxf/fediz/service/oidc/PrivateKeyPasswordProviderImpl.java
+++ 
b/services/oidc/src/main/java/org/apache/cxf/fediz/service/oidc/PrivateKeyPasswordProviderImpl.java
@@ -24,7 +24,7 @@ import 
org.apache.cxf.rs.security.jose.common.PrivateKeyPasswordProvider;
 
 public class PrivateKeyPasswordProviderImpl implements 
PrivateKeyPasswordProvider {
 
-    private String password = "password";
+    private String password;
 
     @Override
     public char[] getPassword(Properties props) {
diff --git a/services/oidc/src/main/webapp/WEB-INF/applicationContext.xml 
b/services/oidc/src/main/webapp/WEB-INF/applicationContext.xml
index b1eb250..b2ee2fe 100644
--- a/services/oidc/src/main/webapp/WEB-INF/applicationContext.xml
+++ b/services/oidc/src/main/webapp/WEB-INF/applicationContext.xml
@@ -141,7 +141,9 @@
         </jaxrs:providers>
     </jaxrs:server>
     
-    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl"/>
+    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl">
+        <property name="password" value="password"/>
+    </bean>
     
     <!-- Client Registration Service -->
     <bean id="clientRegService" init-method="init" 
diff --git a/systests/oidc/src/test/resources/oidc/applicationContext.xml 
b/systests/oidc/src/test/resources/oidc/applicationContext.xml
index 234b493..9d6935a 100644
--- a/systests/oidc/src/test/resources/oidc/applicationContext.xml
+++ b/systests/oidc/src/test/resources/oidc/applicationContext.xml
@@ -147,7 +147,9 @@
         </jaxrs:providers>
     </jaxrs:server>
     
-    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl"/>
+    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl">
+        <property name="password" value="password"/>
+    </bean>
     
     <!-- Client Registration Service -->
     <bean id="clientRegService" init-method="init" 
diff --git 
a/systests/oidc/src/test/resources/oidc/spring/applicationContext.xml 
b/systests/oidc/src/test/resources/oidc/spring/applicationContext.xml
index 0dc4aba..441f3f8 100644
--- a/systests/oidc/src/test/resources/oidc/spring/applicationContext.xml
+++ b/systests/oidc/src/test/resources/oidc/spring/applicationContext.xml
@@ -214,7 +214,9 @@
         </jaxrs:providers>
     </jaxrs:server>
     
-    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl"/>
+    <bean id="keyPasswordProvider" 
class="org.apache.cxf.fediz.service.oidc.PrivateKeyPasswordProviderImpl">
+        <property name="password" value="password"/>
+    </bean>
     
     <!-- Client Registration Service -->
     <bean id="clientRegService" init-method="init" 

Reply via email to