bsloane1650 commented on a change in pull request #314: Add support for
textStandardBase
URL: https://github.com/apache/incubator-daffodil/pull/314#discussion_r366114676
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/schema/annotation/props/ByHandMixins.scala
##########
@@ -95,10 +95,34 @@ object TextNumberBase {
case "8" => 8
case "10" => 10
case "16" => 16
- case _ => self.schemaDefinitionError("Illegal number base: " + str) //
validation will have checked. So this shoudn't happen.
+ case _ => self.schemaDefinitionError("For property textStandardBase,
value must be 2, 8, 10, or 16. Found: %s", str)
Review comment:
Aren't we also testing for this in ElementBaseGrammarMixin? Why do we need
to check twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
