stevedlawrence commented on a change in pull request #316: Assortment of
changes to improve performance
URL: https://github.com/apache/incubator-daffodil/pull/316#discussion_r370363391
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala
##########
@@ -903,7 +903,7 @@ sealed trait DIElement
*/
final def maybeIsNilled: MaybeBoolean = {
if (!_isNilledSet) MaybeBoolean.Nope
- MaybeBoolean(_isNilled)
+ else MaybeBoolean(_isNilled)
Review comment:
Yeah, this definitely feels like a bug, but code coverage does show both
lines as being hit. I'll see if I can figure out when this is used and see if
there's a way to reproduce whatever bug already existed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
