stevedlawrence opened a new pull request #322: Optimize nil combinator parsers URL: https://github.com/apache/incubator-daffodil/pull/322 The nil combinator currently acts as if it is a ChoiceCombinator, where the choices are either a nil parser or a value parser. While this works, the Choice combinator has extra overhead due discriminators, multiple marks, and extra processor errors to help for good diagnostics. But none of this is really needed for the nil combinator This creates a custom nil combinator that is much simpler and has less overhead. Timings show that the SimpleNilOrValueParser went from ~1000us to ~600us on average. In a format where almost every element is nillable, this saw about a 6-7% increase in performance. DAFFODIL-1883
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
