mbeckerle commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393770757
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupDef.scala
##########
@@ -114,21 +102,20 @@ trait GroupDefLike
sealed abstract class GlobalGroupDef(
defXML: Node,
groupXML: Node,
- schemaDocumentArg: SchemaDocument,
- grefArg: => GroupRef,
- override val factory: GlobalGroupDefFactory)
+ schemaDocumentArg: SchemaDocument)
extends AnnotatedSchemaComponentImpl(groupXML, schemaDocumentArg)
with GroupDefLike
with GlobalNonElementComponentMixin
- with NestingTraversesToReferenceMixin
+ with NestingLexicalMixin
with ResolvesLocalProperties // for dfdl:choiceBranchKey
{
- requiredEvaluations(validateChoiceBranchKey)
-
- lazy val groupRef = grefArg // once only
+ def groupMembers = {
Review comment:
Not always required. This does appear to be the big thing in this change
set. How to know when does requiredEvaluations need special treatment or not. I
have to give this some thought as to whether this bother can all be hidden
somehow inside the requiredEvaluations mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
