mbeckerle commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r394609471
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -417,7 +370,7 @@ abstract class ModelGroup(index: Int)
*/
final def mustHaveRequiredElement: Boolean = LV('mustHaveRequiredElement) {
this match {
- case s: SequenceTermBase if s.isHidden => false
+ case s: SequenceTermBase if s.isHiddenGroupRef => false
Review comment:
Yes. This case analysis really shouldn't use SequenceTermBase. I think you
removed this member and added it to only the SGR/CGR class perhaps. That will
come out in the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
