mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r397988578
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/ChoiceTermRuntime1Mixin.scala
 ##########
 @@ -96,20 +91,23 @@ trait ChoiceTermRuntime1Mixin { self: ChoiceTermBase =>
       // get recomputed, but it can appear with a stale value (left-over from 
parse)
       // in the arriving infoset for unparse.
       //
-      val optDefaultBranch = {
-
+      val optDefaultBranchIfHidden = {
 
 Review comment:
   Naming. The "ifHidden" suffix is misleading. This is the default branch, 
hidden or not. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to