[
https://issues.apache.org/jira/browse/DAFFODIL-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson closed DAFFODIL-2305.
-----------------------------------
Verified the specified commit (commit 0e7191ec0afbf7ea44a7dd6018fe921f574591f6)
is included in the latest pull from incubator-daffodil repo.
Verified the specified methods were removed.
Verified all sbt tests executed without error.
Verified data schemas compiled/saved without error.
Verified the nightly performance test suite executed without failure.
> Remove some Unused Term Methods
> -------------------------------
>
> Key: DAFFODIL-2305
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2305
> Project: Daffodil
> Issue Type: Task
> Affects Versions: 2.5.0
> Reporter: Olabusayo Kilo
> Assignee: Olabusayo Kilo
> Priority: Major
> Fix For: 2.6.0
>
>
> There are some methods in Term.scala that are no longer used, and can be
> removed, along with their associated tests.
> possibleFirstChildElementsInInfoset
> The method couldBeLastElementInModelGroup, which has an abstract definition
> below, is also not used and it should be deleted. (The implementations of
> these are in ModelGroup and ElementBase.)
> Ditto for possibleFirstChildTerms
> Ditto for isSequendceChild
> Ditto for possibleNextSiblingTerms
> hasLaterRequiredSiblings is used only by unit tests, so that AND the unit
> tests looking at it can go away (ensure this doesn't decrease coverage if
> other methods are called)
> Same for hasPriorRequiredSiblings.
> priorSibling is unused and can be deleted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
