stevedlawrence commented on a change in pull request #349: Upgrades sbt to
1.3.9, scala to 2.12.11, genjavadoc to 0.16.
URL: https://github.com/apache/incubator-daffodil/pull/349#discussion_r404262482
##########
File path: .github/workflows/main.yml
##########
@@ -59,19 +60,19 @@ jobs:
############################################################
- name: Compile
- run: $SBT compile test:compile it:compile
+ run: $SBTNOCOV compile test:compile it:compile
Review comment:
I think we need to be careful how we do no coverage to prevent unnecessary
compilation. For example, if you do the folowoing:
```
sbt compile
sbt coverage test
```
then I *think* that the first will compile everything. The second will then
have to recompile everything with coverage enabled and then run the test. So we
end up compiling everything twice. That was the reason why "coverage" was added
to the SBT command so that we dont' do a bunch of unnessary compilation. If we
switch back and forth between cov and nocov, we might end up recompiling things
a bunch.
Maybe we should jus do all things that don't do any kindof publishing first
with coverage enabled, then at then do all the things that do publishing and
require no coverage at the en. Then we at least only duplicate compilation once.
This is assuming that there'es a noticable different in time it takes to
finish all the github actions. If it still takes about thes same amount of
time, it might not be worth the effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
