mbeckerle commented on a change in pull request #358: Require grouping and
decimal separators for non-integer types
URL: https://github.com/apache/incubator-daffodil/pull/358#discussion_r405779358
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesZoned.scala
##########
@@ -132,6 +132,7 @@ case class ConvertZonedNumberPrim(e: ElementBase)
roundingMode,
roundingIncrement,
Nil,
+ true,
Review comment:
Something that IDEA has been suggesting to me is to pass args using the
scala convention where you can supply an argument name. When the args have no
defaults like this, and there's a flock of them, it just adds "checked
documentation" to the code, because you still have to supply them all, and in
the right order. But it improves readability to write
`isInt = true,`
rather than just true floating out there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
