mbeckerle commented on issue #361: RuntimeData objects should not carry namespaces URL: https://github.com/apache/incubator-daffodil/pull/361#issuecomment-615328650 Unless we expect the release to be delayed extensively, we're better off not merging. If things drag out, then a temporary branch so work can go forward on a "alternate master" branch would be a way to go, but for now I'd say let's just defer merging a few days. ________________________________ From: Steve Lawrence <[email protected]> Sent: Friday, April 17, 2020 10:03 AM To: apache/incubator-daffodil <[email protected]> Cc: Beckerle, Mike <[email protected]>; Comment <[email protected]> Subject: Re: [apache/incubator-daffodil] RuntimeData objects should not carry namespaces (#361) @stevedlawrence approved this pull request. +1 👍 Thanks for the contribution! Before we merge this, to other Daffodil devs, are there any thoughts on putting a moratorium on merging pull requests during a release vote? Say this was a large complex change and we merged it during a vote. Then say the vote failed and we needed to make a minor fix (e.g. update LICENSE) and create a new release candidate. The complex change isn't going to have as much testing, and could make the new release candidate less stable. In that case, I think it makes sense to hold off on merging the complex change until after the release is out so that it is slated for the following release. We could take it on a case by case basis (in this case, I think it would be fine to merge and include in a new release candidate if there happened to be one), but then we need to define what level of complexity is okay which isn't obvious. It might be easier to just define a rule that says no merging during release votes? Thoughts? This discussion might be more appropriate for the dev list, but I think this is the first PR where this has come up so thought I'd mention it here before we merge. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-daffodil/pull/361#pullrequestreview-395482133>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALUDA7MRCPIQPUZUQR7L4LRNBOTVANCNFSM4MKXP3UQ>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
