mbeckerle commented on a change in pull request #366: Converted many
pass-by-name into pass-by-value for RuntimeData struct…
URL: https://github.com/apache/incubator-daffodil/pull/366#discussion_r410744345
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -422,7 +419,7 @@ trait ElementBase
case Representation.Binary =>
if (isComplexType || (primType != PrimType.HexBinary && primType !=
PrimType.AnyURI)) byteOrderEv // ensure defined
case _ =>
- charsetEv // ensure defined
+ encodingRaw // charsetEv // ensure defined
Review comment:
fix comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
