stevedlawrence commented on a change in pull request #366:
URL: https://github.com/apache/incubator-daffodil/pull/366#discussion_r411354604



##########
File path: 
daffodil-core/src/test/scala/org/apache/daffodil/dsom/TestMiddleEndAttributes.scala
##########
@@ -116,7 +115,8 @@ class TestMiddleEndAttributes {
   @Test def testStaticallyFirstWithChoice {
     val testSchema = SchemaUtils.dfdlTestSchema(
       <xs:include 
schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/>,
-      <dfdl:format representation="text" occursCountKind="parsed" 
lengthUnits="bytes" encoding="US-ASCII" initiator="" terminator="" separator="" 
ignoreCase="no"/>,
+      <dfdl:format representation="text" occursCountKind="parsed" 
lengthUnits="bytes" encoding="US-ASCII" initiator="" terminator="" separator="" 
ignoreCase="no"
+        alignment="1" alignmentUnits="bytes" leadingSkip="0" 
trailingSkip="0"/>,

Review comment:
       Why was this change needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to