tuxji commented on a change in pull request #373:
URL: https://github.com/apache/incubator-daffodil/pull/373#discussion_r416794453



##########
File path: 
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/home_schema.dfdl.xsd
##########
@@ -63,4 +63,6 @@
     </xs:complexType>
   </xs:element>
 
+  <xs:element name="e5" type="xs:string" dfdl:inputValueCalc="{ 
fn:namespace-uri(0) }"/>

Review comment:
       OK, I'll try that!

##########
File path: 
daffodil-test/src/test/scala/org/apache/daffodil/section23/dfdl_expressions/TestDFDLExpressions.scala
##########
@@ -516,10 +516,11 @@ class TestDFDLExpressions {
   //@Test def test_namespace_uri_01() { runner2.runOneTest("namespace_uri_01") 
}
   //@Test def test_namespace_uri_02() { runner2.runOneTest("namespace_uri_02") 
}
   //DFDL-1114
-  //@Test def test_namespace_uri_03() { runner2.runOneTest("namespace_uri_03") 
}

Review comment:
       Yes, we need additional changes to fix DAFFODIL-1101 before 01 and 02 
will pass.  I already have another branch with these changes made and tested 
but I will make a second pull request after this one to make these additional 
changes easier to review.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to