andrewjc2000 commented on a change in pull request #394:
URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r455459024
##########
File path: project/Dependencies.scala
##########
@@ -29,6 +29,7 @@ object Dependencies {
"xml-resolver" % "xml-resolver" % "1.2",
"commons-io" % "commons-io" % "2.6",
"jline" % "jline" % "2.14.6",
+ "org.scalatest" %% "scalatest" % "3.2.0" % "test"
Review comment:
Noted, I did not realize the flaws of ScalaTest; the particular test
cases I wrote happened to be helpful for representing the structure of the
large schema files I wanted to verify I had the correct NiFi RecordSchema for,
but I realize now how it might be more alienating for non-native English
speakers, plus Unit Tests shouldn't be based around very large structures
happening to work and should be more focused.
That all said, I developed a new testing file in the latest revision that
uses JUnits and while it is much simpler than what I had before. it is still a
bit robust in that it checks to see if all the important Simple and Complex
View types work as expected. It is also based around a much simpler
implementation of the Abstract Walker. Feel free to comment on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
