stevedlawrence commented on a change in pull request #419:
URL: https://github.com/apache/incubator-daffodil/pull/419#discussion_r488069432
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetWalker.scala
##########
@@ -178,7 +179,11 @@ class InfosetWalker private (
* we increment this value on the top of the stack so that the starting index
* is correct.
*/
- private var containerNode: DINode = startingContainerNode
+ private var containerNodeStack: MStackOf[DINode] = {
Review comment:
I think the issue was that containerNode requires a DINode, but parent
is an InfosetElement, so we have to do instanceOf/asInstanceOf checks. Whatever
bytecode this turns into appears to be relatively slow. If we got rid of all
the InfosetElement distinction, we could probably get rid of alot of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
