jw3 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r503922070
##########
File path:
daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
##########
@@ -73,6 +73,8 @@ private[japi] object ValidationConversions {
case ValidationMode.Off => SValidationMode.Off
case ValidationMode.Limited => SValidationMode.Limited
case ValidationMode.Full => SValidationMode.Full
+ // todo;; support custom in java?
+ case _ => SValidationMode.Off
Review comment:
Not sure how to approach this
##########
File path:
daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
##########
@@ -82,6 +84,8 @@ private[japi] object ValidationConversions {
case SValidationMode.Off => ValidationMode.Off
case SValidationMode.Limited => ValidationMode.Limited
case SValidationMode.Full => ValidationMode.Full
+ // todo;; support custom in java?
+ case _ => ValidationMode.Off
Review comment:
Not sure how to approach this
##########
File path:
daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
##########
@@ -80,6 +82,8 @@ private[sapi] object ValidationConversions {
case SValidationMode.Off => ValidationMode.Off
case SValidationMode.Limited => ValidationMode.Limited
case SValidationMode.Full => ValidationMode.Full
+ // todo;; hacking this out for now
+ case _ => ValidationMode.Off
Review comment:
Not sure how to approach this
##########
File path:
daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
##########
@@ -71,6 +71,8 @@ private[sapi] object ValidationConversions {
case ValidationMode.Off => SValidationMode.Off
case ValidationMode.Limited => SValidationMode.Limited
case ValidationMode.Full => SValidationMode.Full
+ // todo;; hacking this out for now
+ case _ => SValidationMode.Off
Review comment:
Not sure how to approach this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
