jw3 commented on a change in pull request #431: URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r504647514
########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/Validator.scala ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.api + +import org.xml.sax.ErrorHandler + +trait Validator { + def name(): String = getClass.getTypeName.toLowerCase + + def checkArgs(args: Validator.Arguments): Either[String, Unit] = Right(()) + + def validateXML(document: java.io.InputStream, errHandler: ErrorHandler, args: Validator.Arguments): Unit Review comment: Here is a sketch in another branch, if its close Ill move it over and we can advance it, just didnt want to blow this PR up if it was way off. https://github.com/jw3/incubator-daffodil/commit/d9f7f4346e57e12aa2d14e24c5c5ca0581124a26 I like the compiled approach, it addresses a few pain points and it ends up being more flexible to allow non-spi usage for API clients as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
