jw3 commented on pull request #431: URL: https://github.com/apache/incubator-daffodil/pull/431#issuecomment-710030435
>I still have concerns that even with something like typesafe config, we're still limiting Validation configuration to what can be represented by some configuration language (e.g. typesafe) just so that we can get plugability. I take from this your concern is that you want to ensure validator instances can be built and passed programmatically, not only be based on a SPI based name lookup and argument bundle. >I can imagine Validators that really can only be configured with code, granted I'm not sure if anything like that exists in the real world. Like I said somewhere above, the arg handling has gotten out of hand. I want to reduce that and make the API aspect more ergonomic while being compatible with passing things from the CLI. The focus on CLI first instead of API first is what has skewed the initial approach. >And I don't personally feel that plugability gains much outside of CLI support. There are plenty of applications that use SPI to supplement API usage. Probably more useful to show compelling examples in this PR than to debate this point though, so Ill work on that and evolve this over the next few days. Im still confident the current impl can be tweaked to address the API side concerns. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
