stevedlawrence commented on pull request #439: URL: https://github.com/apache/incubator-daffodil/pull/439#issuecomment-710082987
Yeah, I think you're reading the codecov right. It was correct that parts of this diff weren't covered, but how it showed that, as you say, doesn't feel right. If I run the commands to generate a coverage report locally, it feels a little more correct, but still not quite right. I think the challenge is just that Scala doesn't a bunch of stuff behind the scense, and the coverge tools just can't make an accurate represetnation of what's going on. But it was correct that we didn't have CLI tests for different infoset types, and so no actual coverage for some of these changes I just made, and I think it was worth adding just to make sure we don't have any regressions in the future. The way this infosetDataToInputterData and getInfosetInputter is sort of fragile since they retun/accept AnyRef, so it's important that they have a little coverage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
