mbeckerle commented on a change in pull request #440:
URL: https://github.com/apache/incubator-daffodil/pull/440#discussion_r507970802



##########
File path: 
daffodil-test/src/test/resources/org/apache/daffodil/section07/variables/variables.tdml
##########
@@ -1752,7 +1751,18 @@
         </root>
       </tdml:dfdlInfoset>
     </tdml:infoset>
-  </tdml:parserTestCase>
+    <tdml:warnings>
+      <tdml:warning>Multiple choice branches</tdml:warning>
+      <tdml:warning>no required elements</tdml:warning>
+      <tdml:warning>selecting the first branch</tdml:warning>
+    </tdml:warnings>
+
+    <tdml:errors>

Review comment:
       Please add block comment to this TDML test because this is an obscure 
enough case that it needs some explanation. 
   Suggest name of test should be "multipleBranchesWIthNoElementsDoubleWrite" 
or something conveying the complexity of the situation. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to