olabusayoT commented on a change in pull request #436:
URL: https://github.com/apache/incubator-daffodil/pull/436#discussion_r508755383
##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -779,24 +781,33 @@ object Main extends Logging {
}
}
}
+ case "sax" => data
}
}
- def getInfosetInputter(infosetType: String, anyRef: AnyRef): InfosetInputter
= {
+ def getInfosetInputter(
+ infosetType: String,
+ anyRef: AnyRef,
+ processor: Option[DFDL.DataProcessor] = None,
+ outChannel: Option[DFDL.Output] = None): Either[InfosetInputter,
DFDL.DaffodilInputContentHandler] = {
Review comment:
The "= None" was intended as the default for the arguments so the nonSAX
infosetTypes wouldn't need to pass in anything for the processor and outChannel
params. But in both places I call it, we're passing in Some(_), so I removed
the option and default.
I could change it so we pass in these 2 variables in a tuple via the anyRef,
but I thought this way would be clearer since the anyRef is intended to
represent inputterData
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
