stevedlawrence commented on pull request #451: URL: https://github.com/apache/incubator-daffodil/pull/451#issuecomment-723123861
Good call on updating the workflow. Will do. Maybe it's also worth adding a note in the .gitignore file that it should not include OS/IDE related files and to use the other options instead? Regarding accidental commits of OS/IDE files, I'd guess that in the majority of cases, if not all, those files won't have an Apache license, which means they will fail the ratCheck. So that should hopefully catch the cases where contributors just do something like ``git add . && git commit``. But still something to be aware of for sure, it's definitely possible for these files to include licenses that rat won't have a problem with. We also need to keep an eye out for .gitignore or ratExcludes changes that include OS/IDE files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
