stevedlawrence commented on pull request #453: URL: https://github.com/apache/incubator-daffodil/pull/453#issuecomment-725416614
+1 :+1: Nice change and the numbers look great! Overhead of SAX now seems much smaller. I guess we've learned a good lesson, that context switching between threads is extremely expensive. We probably want to avoid use of the coroutine in the future unless 1) we are batching like this change does or 2) the coroutines naturally don't need to context switch very often. 3.0 will hopefully be release soon once we get some votes from IPMC, so let's hold off on merge this until then. If we need an rc2, this might be a good candidate to add to that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
