jadams-tresys commented on a change in pull request #450:
URL: https://github.com/apache/incubator-daffodil/pull/450#discussion_r538756972
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/VariableMap1.scala
##########
@@ -222,7 +300,7 @@ class VariableMap private(vTable: Map[GlobalQName,
MStackOf[VariableInstance]])
/**
* For testing mostly.
*/
- def getVariableBindings(qn: GlobalQName): MStackOf[VariableInstance] = {
+ def getVariableBindings(qn: GlobalQName): Queue[VariableInstance] = {
Review comment:
A stack is the ideal structure for this as with newVariableInstance we
are pushing and popping VariableInstance's as they go in and out of scope.
That being said, you are right that an ArrayBuffer will work just fine and I'm
sure would be more efficient. I'll make the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
