jadams-tresys commented on a change in pull request #450:
URL: https://github.com/apache/incubator-daffodil/pull/450#discussion_r539450069
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section07/variables/variables.tdml
##########
@@ -1884,4 +1976,63 @@
</tdml:infoset>
</tdml:parserTestCase>
+ <tdml:defineSchema name="circular_defineVariable">
+ <xs:include
schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/>
+ <dfdl:format ref="ex:GeneralFormat" />
+
+ <dfdl:defineVariable name="circular1" type="xs:int"
+ defaultValue="{ $ex:circular2 }" />
+ <dfdl:defineVariable name="circular2" type="xs:int"
+ defaultValue="{ $ex:circular1 }" />
+ <xs:element name="root" type="xs:int" dfdl:inputValueCalc="{ $ex:circular1
}" />
+
+ </tdml:defineSchema>
+
+ <tdml:parserTestCase name="circular_defineVariable_err" root="root"
+ model="circular_defineVariable" description="Section 7 - ">
+ <tdml:document/>
+ <tdml:errors>
+ <tdml:error>Runtime Schema Definition Error</tdml:error>
+ <tdml:error>part of circular definition</tdml:error>
+ </tdml:errors>
+ </tdml:parserTestCase>
+
+ <tdml:defineSchema name="defineVariable_ref_infoset">
+ <xs:include
schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/>
+ <dfdl:format ref="ex:GeneralFormat" />
+
+ <dfdl:defineVariable name="badRef" type="xs:int"
+ defaultValue="{ ex:root }" />
+ <xs:element name="root" type="xs:int" dfdl:inputValueCalc="{ 42 }" />
+
+ </tdml:defineSchema>
+
+ <tdml:parserTestCase name="defineVariable_ref_infoset_err" root="root"
+ model="defineVariable_ref_infoset" description="Section 7 - ">
+ <tdml:document/>
+ <tdml:errors>
+ <tdml:error>????</tdml:error>
+ </tdml:errors>
+ </tdml:parserTestCase>
+
+ <tdml:defineSchema name="defineVariable_ref_noDefault">
+ <xs:include
schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/>
+ <dfdl:format ref="ex:GeneralFormat" />
+
+ <dfdl:defineVariable name="noDefault" type="xs:int" />
+ <dfdl:defineVariable name="badRef" type="xs:int"
+ defaultValue="{ $ex:noDefault }" />
+ <xs:element name="root" type="xs:int" dfdl:inputValueCalc="{ $ex:badRef }"
/>
+
+ </tdml:defineSchema>
+
+ <tdml:parserTestCase name="defineVariable_ref_noDefault_err" root="root"
+ model="defineVariable_ref_noDefault" description="Section 7 - ">
+ <tdml:document/>
+ <tdml:errors>
+ <tdml:error>Runtime Schema Definition Error</tdml:error>
+ <tdml:error>has no value. It was not set</tdml:error>
+ </tdml:errors>
+ </tdml:parserTestCase>
+
Review comment:
This should work, but you are right, definitely should have a test to
ensure that it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
