tuxji commented on a change in pull request #471:
URL: https://github.com/apache/incubator-daffodil/pull/471#discussion_r558327251
##########
File path:
daffodil-runtime2/src/main/scala/org/apache/daffodil/runtime2/generators/CodeGeneratorState.scala
##########
@@ -247,10 +264,12 @@ class CodeGeneratorState {
val erds = this.erds.mkString("\n")
val finalImplementation = this.finalImplementation.mkString("\n")
val code =
- s"""#include "generated_code.h" // for generated code structs
- |#include <endian.h> // for be32toh, htobe32, etc.
- |#include <stddef.h> // for ptrdiff_t
- |#include <stdio.h> // for NULL, fread, fwrite, size_t, FILE
+ s"""#define __STDC_WANT_IEC_60559_BFP_EXT__
Review comment:
I needed this WANT_IEC_60559_BFP to make <math.h> provide the signaling
NaN macros (SNAN, SNANF), but I ended up removing that define in my second
commit because it didn't work on Windows. I decided it wasn't worth trying to
initialize fields with SNAN/SNANF (too unportable) and initialized them with
NAN instead (a more portable macro).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
