stevedlawrence commented on a change in pull request #463:
URL: https://github.com/apache/incubator-daffodil/pull/463#discussion_r560155294
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/AnnotatedSchemaComponent.scala
##########
@@ -400,7 +400,12 @@ trait AnnotatedMixin { self: AnnotatedSchemaComponent =>
{
ai.attribute("source") match {
case None => {
- this.SDW(WarnID.AppinfoNoSource, """xs:appinfo without source
attribute. Is source="http://www.ogf.org/dfdl/"; missing?""")
+ // if a child node in the dfdl namespace exists we will provide a
warning about using the source property
+ ai.child.flatMap(n =>
Option(n.namespace)).find{_.contains("dfdl")}.foreach { _ =>
Review comment:
In the ``case Some`` below, we use contains("ogf") || contains("dfdl")
to consider a DFDL namespace "acceptable". Should we use the same logic here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
