stevedlawrence commented on a change in pull request #485:
URL: https://github.com/apache/incubator-daffodil/pull/485#discussion_r568732479
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml
##########
@@ -2415,4 +2417,23 @@
</tdml:infoset>
</tdml:parserTestCase>
+ <!--
+ Test name: schemaNoGlobalElems_03
+ Schema: multi_base_21.dfdl.xsd
+ Root: base2
+ Purpose: This test demonstrates that you can have a schema if there are
+ no global elements in the primary schema, as long as the root
element is
+ specified (the TDML Runner always specifies the root)
Review comment:
Yeah, the root attribute is technically redundant. I don't think that
was always the case, not sure when that feature was added. I wonder if we
should have have a daffodil standard that the root attribute shouldn't be
provided for positive test cases? I do kindof like it just for the sanity
check. I know I sometimes copy the infoset from another test and forget to
update the root element. In that case I get an error about the root attribute
not matching.
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml
##########
@@ -2415,4 +2417,23 @@
</tdml:infoset>
</tdml:parserTestCase>
+ <!--
+ Test name: schemaNoGlobalElems_03
+ Schema: multi_base_21.dfdl.xsd
+ Root: base2
+ Purpose: This test demonstrates that you can have a schema if there are
+ no global elements in the primary schema, as long as the root
element is
+ specified (the TDML Runner always specifies the root)
+ -->
+
+ <tdml:parserTestCase name="schemaNoGlobalElems_03"
+ root="distant_element" model="multi_base_21.dfdl.xsd" description="">
Review comment:
Ah yeah, I missed this comment. I do like the consistency check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
