stevedlawrence commented on pull request #489:
URL:
https://github.com/apache/incubator-daffodil/pull/489#issuecomment-775990558
> That's another reason why we need to fix the scala compiler warning
settings. In principle it should have told us there were no reads of prior
pointer right?
I'm not sure. There was technically a read here in this code that was
removed:
```scala
private var _prior: UStateForSuspension = null
override def prior = _prior
```
And although the ``def prior`` is never called anywhere in Daffodil, it is a
public function so theoretically could be used by library using Daffodil. I
think because of that scalac wouldn't warn about that. We probably need to get
much better at marking things as public/private/protected before we get unused
warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
