stevedlawrence commented on pull request #490: URL: https://github.com/apache/incubator-daffodil/pull/490#issuecomment-777462074
It would also be really helpful to add a test so that this new code has some test coverage to make sure we don't accidentally break this in the future. It looks like we have similar tests in ``daffodil-test/src/test/resources/org/apache/daffodil/section10/representation_properties/encodings.tdml``. The easiest way to add this test would be to: 1. Copy the ``eString`` element to make a new element with this new encoding 2. Copy the ``ebcidc1`` parserTestCase to create a new parserTestCase with a unique name and that uses your new element as the root With that done, you just need to modify ``daffodil-test/src/test/scala/org/apache/daffodil/section10/representation_properties/TestRepProps2.scala`` and copy ``def test_ebcdic1`` to run your new parser test case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
