[ 
https://issues.apache.org/jira/browse/DAFFODIL-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Thompson closed DAFFODIL-313.
----------------------------------
    Resolution: Fixed

Verified all tests identified throughout the comments dealing with white space 
now execute/pass successfully. 

Modified several of these test to generate an error message. Each error message 
seemed appropriate.

> Better diagnostic message for incorrect syntax when a DFDL property is an 
> expression
> ------------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-313
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-313
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Diagnostics, Front End, Usability
>            Reporter: Paul Chu
>            Priority: Minor
>              Labels: reverify
>
> Regarding the test, ocke_rel, for occursCountKind=���expression��� in 
> daffodil-test\src\test\scala-debug\daffodil\section23\dfdl_expressions\TestDFDLExpressionsDebug.scala:
> Mike Beckerle's comments: 
> Oh wow. This test fails because it has dfdl:occursCount=" {...} "
> Note the white spaces before { and after }.
> If you take those out so it is dfdl:occursCount="{...}"  then the test passes.
> So, there is a bug here that there is no reasonable diagnostic at all. 
> Technically, if { is not the very first character of the property value, then 
> you gave it a string as the value, not an expression. 
> I suggest the issue should be fixed in CompiledExpression, which should do a 
> better job helping find this kind of error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to