stevedlawrence commented on pull request #481:
URL: https://github.com/apache/daffodil/pull/481#issuecomment-801093746


   I think lengthKind="terminator" was a typo. The actual message does 
correctly have lengthKind="delimited".
   
   The question I had was why does the DFDL spec say ``ES`` can never be used 
in the ``dfdl:separator`` property, but it can be used in the 
``dfdl:terminator`` property as long as it isn't alone as one of the string 
literals when lengthKind="delimited"? What's the usecase for ever needing ES in 
``dfdl:terminator``?
   
   But thinking about it, I guess the usecase is an optional terminator with 
with non-delimited lengths. So something like ``dfdl:terminator="FOO %ES;"`` 
seems reasonable when lengthKind is not delimited. So I guess I answered my own 
question.
   
   So @regetom, I think this does mean we need two separate Cookers. One is 
needed for cooking separators that is called DelimiterCookerNoES (same as what 
you have now), and one called something like DelimterCookerNoSoleES which is 
like the old DelimiterCookerNoES (has no restriction on character class, with 
the only restriction being sole ES/WSP*).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to