mbeckerle commented on a change in pull request #521:
URL: https://github.com/apache/daffodil/pull/521#discussion_r607196281
##########
File path: daffodil-test-ibm1/src/test/scala/org/apache/daffodil/IBMTests.scala
##########
@@ -44,8 +44,7 @@ class IBMTestsThatPass {
@Test def test_length_delimited_12_01(): Unit = {
runner1.runOneTest("length_delimited_12_01") }
@Test def test_length_delimited_12_04(): Unit = {
runner1.runOneTest("length_delimited_12_04") }
- // Doesn't work for a user, possible locale issue (DAFFODIL-1945)
- // @Test def test_simple_type_properties_text_calendar_13_01() {
runner2.runOneTest("simple_type_properties_text_calendar_13_01") }
+ @Test def test_simple_type_properties_text_calendar_13_01(): Unit = {
runner2.runOneTest("simple_type_properties_text_calendar_13_01") }
Review comment:
So this is just being re-enabled. No other change was required.
Makes me think we should try (not in this change set, but separately) grep
for all commented out tests, and then re-enable and try them. Some may well be
fixed now.
I did
`grep -Pr '(?<=//).*@Test' | wc -l`
in both daffodil-test/src/test/scala and daffodil-test-ibm1/src/test/scala,
and I got 134 and 15 back respectively.
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml
##########
@@ -5935,12 +5935,13 @@
-->
<tdml:parserTestCase name="dateCalendarDaysInFirstWeek5" root="date20"
- model="dateTimeSchema" description="Section 13 Simple Types -
calendarDaysInFirstWeek - DFDL-13-143R">
+ model="dateTimeSchema" description="Section 13 Simple Types -
calendarDaysInFirstWeek - DFDL-13-143R"
+ roundTrip="twoPass">
Review comment:
Does this test really have to be twoPass? Can you add a comment as to
why twoPass is correct here?
(I'm guessing unparse creates "01 03 2013" (leading zero), but I'm just
guessing)
It's so easy for twoPass to mask incorrect calendar parse behavior. Maybe we
should just change this to two test cases, both roundTrip='none', one a
parserTestCase, one an unparserTestCase? That would nail down exactly the right
behavior for this particular calendarPattern parse/unparse. To avoid
renumbering confusion, I usually rename tests with a "p" or "u" suffix when I
split them like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
