[
https://issues.apache.org/jira/browse/DAFFODIL-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331664#comment-17331664
]
Mike Beckerle commented on DAFFODIL-2502:
-----------------------------------------
It's not the entire fix.
Tests
* {color:#00627a}testDaffodilParseFromNetworkDelimited1
{color}
* {color:#00627a}testDaffodilParseFromNetworkDelimited2{color}
{color:#00627a}are commented out because they still fail.{color}
{color:#00627a}These are testing whether we get proper behavior when parsing
with lengthKind 'delimited'.{color}
{color:#00627a}E.g., suppose we have a string terminated by '$'.{color}
{color:#00627a}Then 1234$ should parse and return a result. It doesn't. More
data must be provided. {color}
{color:#00627a}Furthermore suppose we have dfdl:terminator="$ $$". {color}
{color:#00627a}Then 1234$ should block, but when we write another '$' to the
stream, the parser should now detect that there is a match for the
longest-possible delimiter and return a result. It doesn't. More data must be
provided. {color}
{color:#00627a}tests{color}
* {color:#00627a}testDaffodilParseFromNetworkDelimited1b{color}
* {color:#00627a}testDaffodilParseFromNetworkDelimited2b{color}
{color:#00627a}characterize the behavior - they show that you need to provide 7
more characters of data before the parse will return. {color}
> Parse must behave properly for reading data from TCP sockets
> ------------------------------------------------------------
>
> Key: DAFFODIL-2502
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2502
> Project: Daffodil
> Issue Type: Bug
> Components: API, Back End
> Affects Versions: 3.0.0
> Reporter: Mike Beckerle
> Assignee: Mike Beckerle
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Daffodil assumes the input streams are like files - reads are always blocking
> for either 1 or more bytes of data, or End-of-data.
> People want to use Daffodil to read data from TCP/IP sockets. These can
> return 0 bytes from a read because there is no data available, but that does
> NOT mean the end of data. It's just a temporary condition. More data may come
> along.
> Daffodil's InputSourceDataInputStream is wrapped around a regular Java input
> stream, and enables us to support incoming messages which do not conform to
> byte-boundaries.
> The problem is that there's no way for users to wrap an
> InputSourceDataInputStream around a TCP/IP socket, and have it behave
> properly when a read() call temporarily says 0 bytes available.
> Obviously we don't want to sit in a tight loop just retrying the read until
> we get either some bytes or end-of-data.
> The right API here is that if the read() of the underlying java stream
> returns 0 bytes, that a hook function supplied by the API user is called.
> One obvious thing a user can do is put a call to Thread.yield() in the hook.
> (That might even want to be the default behavior if they supply no hook.)
> Then if they have a separate thread parsing the data with daffodil, that
> thread will at least yield the CPU, i.e., behave politely in a multi-threaded
> world.
> More advanced usage could start a Daffodil parse using co-routines, returning
> control to the caller when the parse must pause due to read() of the Java
> input stream returning 0 bytes.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
