[ 
https://issues.apache.org/jira/browse/DAFFODIL-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Beckerle updated DAFFODIL-2509:
------------------------------------
    Description: 
We should turn off CodeCov coverage testing for all
 * Assert.invariantFailed
 * Assert.usageError
 * Assert.impossible
 * Assert.impossibleCase
 * Assert.notYetImplemented()
 * Assert.nyi()
 * Assert.abort()

These are, by definition, things we either cannot test (can't get the code to 
take those paths at all), or are unnecessary to have test coverage on.

The implementations of these things can also have coverage testing turned off 
for them.

[https://github.com/scoverage/sbt-scoverage#exclude-classes-and-packages]

So we could maybe do something like:


{code:java}
foo match {     
  case real1 => ...     
  case real2 => ... r    

  // $COVERAGE-OFF    

  case thingy =>   Assert.invariantFailed(".....msg...")    

  // $COVERAGE-ON  

}
{code}
 

 

  was:
We should turn off CodeCov coverage testing for all 
 * Assert.invariantFailed
 * Assert.usageError
 * Assert.impossible
 * Assert.impossibleCase
 * Assert.notYetImplemented()
 * Assert.nyi()
 * Assert.abort()

These are, by definition, things we either cannot test (can't get the code to 
take those paths at all), or are unnecessary to have test coverage on.


The implementations of these things can also have coverage testing turned off 
for them. 

[https://github.com/scoverage/sbt-scoverage#exclude-classes-and-packages]
 
 So we could maybe do something like:
 ```
   foo match {
     case real1 => ...
     case real2 => ... r
     // $COVERAGE-OFF
     case thingy =>   Assert.invariantFailed(".....msg...")
     // $COVERAGE-ON
   }
 ```


> Add COVERAGE-OFF/ON to invariantFailed and usageError calls
> -----------------------------------------------------------
>
>                 Key: DAFFODIL-2509
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2509
>             Project: Daffodil
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Mike Beckerle
>            Priority: Minor
>
> We should turn off CodeCov coverage testing for all
>  * Assert.invariantFailed
>  * Assert.usageError
>  * Assert.impossible
>  * Assert.impossibleCase
>  * Assert.notYetImplemented()
>  * Assert.nyi()
>  * Assert.abort()
> These are, by definition, things we either cannot test (can't get the code to 
> take those paths at all), or are unnecessary to have test coverage on.
> The implementations of these things can also have coverage testing turned off 
> for them.
> [https://github.com/scoverage/sbt-scoverage#exclude-classes-and-packages]
> So we could maybe do something like:
> {code:java}
> foo match {     
>   case real1 => ...     
>   case real2 => ... r    
>   // $COVERAGE-OFF    
>   case thingy =>   Assert.invariantFailed(".....msg...")    
>   // $COVERAGE-ON  
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to