tuxji commented on a change in pull request #570:
URL: https://github.com/apache/daffodil/pull/570#discussion_r635231301
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/dfa/TextDelimitedUnparser.scala
##########
@@ -248,6 +248,8 @@ class TextDelimitedUnparser(override val context:
TermRuntimeData)
escapeEscapeChar: MaybeChar, state: UState): (String, Boolean) = {
Assert.invariant(delims != null)
Assert.invariant(field != null)
+ if (hasEscCharAsDelimiter)
+ UnparseError(One(context.schemaFileLocation),
One(state.currentLocation), "Delimiters may not begin with the
dfdl:escapeCharacter (%s)", escapeChar)
Review comment:
If every schema and every TDML test fails the
checkDelimiterEscapeConflict check before they can hit this line, it may be
difficult to write a test that covers this line. We'd have to write a unit
test that calls this specific method to hit this line or tell Codecov to ignore
this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
