stevedlawrence commented on a change in pull request #560:
URL: https://github.com/apache/daffodil/pull/560#discussion_r638703141
##########
File path:
daffodil-japi/src/test/java/org/apache/daffodil/example/TestJavaAPI.java
##########
@@ -1008,6 +1031,7 @@ public void testJavaAPI20() throws IOException,
ClassNotFoundException {
try {
org.xml.sax.XMLReader unparseXMLReader =
javax.xml.parsers.SAXParserFactory.newInstance()
.newSAXParser().getXMLReader();
+ setSecureDefaults(unparseXMLReader);
Review comment:
I'd argue they should do neither. Both are internal use only functions.
Any one creating a XMLReader outside of Daffodil (like for use with SAX
unparsing) should be seureing their own XMLReader. We may want to consider
making a public XMLUtils library at some point, but right now we don't have
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
