mbeckerle commented on a change in pull request #630:
URL: https://github.com/apache/daffodil/pull/630#discussion_r701279055



##########
File path: 
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml
##########
@@ -562,10 +562,10 @@
     <xs:element name="e_lowercase2" type="xs:string" dfdl:inputValueCalc="{ 
fn:lower-case('TeSt LoWeR') }" />
     <xs:element name="e_lowercase3" type="xs:string" dfdl:inputValueCalc="{ 
fn:lower-case('') }" />
 
-    <xs:element name="e_contains1" type="xs:boolean" dfdl:inputValueCalc="{ 
fn:contains('The quick brown fox.', 'quick') }" />

Review comment:
       This one surprised me. I have no objection to the change. I just wonder 
if I can be conscious enough about language to avoid things as common as this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to