[
https://issues.apache.org/jira/browse/DAFFODIL-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Lawrence resolved DAFFODIL-1104.
--------------------------------------
Resolution: Not A Bug
Looking at the mentioned files, it looks like everything has already been
updated to no longer used Calendars, but instead use DFDLDate/Time/DateTime.
The assert that I think this mentions asserts for the DFDLCalendar types. And
functions mentioned (although in different files) all create DFDLCalendar types
directly, or use use DFDL*Conversions to convert strings to DFDLCalendar
types. Also looking at parsers/unparsers that write to the infoset, they all
seem to be using DFDLCalendar types.
This appears to be already fix by other changes.
Also, I think we do still need the DFDLCalendar types to provide extra
functionality that the Java Calendar doesn't provide.
Resolving as not a bug.
> Should this be DFDLCalendar?
> ----------------------------
>
> Key: DAFFODIL-1104
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1104
> Project: Daffodil
> Issue Type: Improvement
> Components: Clean Ups
> Reporter: Mike Beckerle
> Priority: Major
>
> line 161 of DPath.scala (on serialization-with-dpath4 branch), this is an
> assert checking if a result from an expression is type Calendar.
> This probably should be DFDLCalendar, but it's also probably the case that
> nothing exercises this code path, so we need a test that exercises it to be
> sure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
