stevedlawrence commented on pull request #640: URL: https://github.com/apache/daffodil/pull/640#issuecomment-924866464
I've looked at all all uses for `replaceAll`, and I don't see any uses that could contain a back slash or a dollar sign. All instances use a hardcoded replacement values, or are now properly escaped with this change. The one exception was for code that used to handle `dfdl:outputNewLine`, which could theoretically contain a dollar sign, but that is dead code. That property is now handled without `replaceAll`. I've just removed that function to remove the possibility of every using it with bad input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
