[ 
https://issues.apache.org/jira/browse/DAFFODIL-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421026#comment-17421026
 ] 

Mike Beckerle commented on DAFFODIL-2565:
-----------------------------------------

Changed from bug to improvement. Turns out code was not wrong. Just a cleanup 
to make it clearer what code is responsible for maintaining the 
changedVariablesStack (answer: PState is, exclusively, and VariableMap doesn't 
know anything about the changedVariablesStack.)

> PState.changedVariablesStack not being maintained by VRef in DPath expressions
> ------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2565
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2565
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Back End
>    Affects Versions: 3.1.0
>            Reporter: Mike Beckerle
>            Assignee: Mike Beckerle
>            Priority: Major
>
> By inspection found that while PState.setVariable was maintaining the 
> changedVariableStack, other places that read variables were not. 
> Specifically, in DPath expression evaluation, VRef is not. 
> We should do all variable sets/gets from PState/UState so as to always 
> maintain this stack properly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to