stevedlawrence commented on a change in pull request #645:
URL: https://github.com/apache/daffodil/pull/645#discussion_r717760719
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
##########
@@ -600,4 +598,8 @@ final class CompileState(tci: DPathCompileInfo,
maybeDataProc: Maybe[DataProcess
def regexMatchBuffer: CharBuffer = Assert.usageError("Not to be used.")
def regexMatchBitPositionBuffer: LongBuffer = Assert.usageError("Not to be
used.")
+
+ override def setVariable(vrd: VariableRuntimeData, newValue:
DataValuePrimitive, referringContext: ThrowsSDE): Unit = Assert.usageError("Not
to be used.")
+
+ override def getVariable(vrd: VariableRuntimeData, referringContext:
ThrowsSDE) = Assert.usageError("Not to be used.")
Review comment:
Can you add the coverage-off/on annotations hide these warnings?
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/UState.scala
##########
@@ -74,6 +76,21 @@ abstract class UState(
extends ParseOrUnparseState(vbox, diagnosticsArg, dataProcArg, tunable)
with Cursor[InfosetAccessor] with ThrowsSDE with SavesErrorsAndWarnings {
+ final override def setVariable(vrd: VariableRuntimeData, newValue:
DataValuePrimitive, referringContext: ThrowsSDE) =
+ vbox.vmap.setVariable(vrd, newValue, referringContext, this)
Review comment:
This is surprising that setVariable is never called on UState? Did we
miss a place where setVariable should be called? Or do we have no unparse tests
that call setVariable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
